Uh oh!
There was an error while loading. Please reload this page.
Update rector.php - #111
Merged
Merged
Conversation
kenjis
marked this pull request as draft
September 7, 2023 01:27
MGatner
commented
Sep 9, 2023
Member
Consider moving Rector from |
kenjis
marked this pull request as ready for review
September 10, 2023 20:55
kenjis
commented
Sep 10, 2023
MemberAuthor
@MGatner What is it? Can you give me a reference? Ah, this repo is devkit, and if you install this as dev dependency, it should also install rector? |
MGatner
commented
Sep 11, 2023
Member
Correct! So our other libraries that depend on DevKit won't need to add Rector to their dev requirements. I think we want Rector everywhere so this would be a safe, central place to control the version. |
1 task
kenjis
commented
Sep 11, 2023
MemberAuthor
That makes sense! |
MGatner
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update from codeigniter4/shield#811