') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); chore: use workflows in codeigniter4/.github by kenjis · Pull Request #811 · codeigniter4/shield · GitHub
Skip to content

chore: use workflows in codeigniter4/.github - #811

Merged
kenjis merged 6 commits into
codeigniter4:developfrom
kenjis:reuse-workflows
Sep 9, 2023
Merged

chore: use workflows in codeigniter4/.github#811
kenjis merged 6 commits into
codeigniter4:developfrom
kenjis:reuse-workflows

Conversation

@kenjis

@kenjiskenjis commented Sep 6, 2023•
edited
Loading

Copy link
Copy Markdown
Member

@kenjiskenjis added the github_actions Pull requests that update GitHub Actions code label Sep 6, 2023
@kenjis
kenjis marked this pull request as draft September 6, 2023 06:57
@kenjiskenjis mentioned this pull request Sep 6, 2023
Closed
9 tasks
@kenjiskenjis mentioned this pull request Sep 6, 2023
Merged
@kenjis
kenjis marked this pull request as ready for review September 6, 2023 08:40
datamweb
datamweb approved these changes Sep 6, 2023
View reviewed changes

@datamwebdatamweb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I always have a problem with one repo being dependent on another. However, I understand the benefits of this work for the team. You are trying to eliminate duplicate tasks.

codeigniter4/.github It seems to be public, and I assume so any repo can use this method even if it is not under organization?

@datamwebdatamweb mentioned this pull request Sep 6, 2023
Closed
datamweb
datamweb reviewed Sep 6, 2023
View reviewed changes
Comment threadcomposer.json Outdated
@kenjis@datamweb
chore: update rector
fdf6af2
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
@kenjis

kenjis commented Sep 7, 2023

Copy link
Copy Markdown
MemberAuthor

codeigniter4/.github It seems to be public, and I assume so any repo can use this method even if it is not under organization?

Yes.

The called workflow is stored in a public repository, and your organization allows you to use public reusable workflows.
https://docs.github.com/en/actions/using-workflows/reusing-workflows#access-to-reusable-workflows

MGatner
MGatner approved these changes Sep 9, 2023
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I think using Rector as a non-dependency is technically better I think this ends up being cleaner and safer. I will move my own work in the same direction.

@kenjis
kenjis merged commit 40cd12b into codeigniter4:developSep 9, 2023
@kenjis
kenjis deleted the reuse-workflows branch September 9, 2023 20:03
@kenjis

kenjis commented Sep 9, 2023

Copy link
Copy Markdown
MemberAuthor

@MGatner If we don't have rector, devs cannot run rector.
And PhpStorm always complains about "Undefined class" in rector.php.

rector.php is closely related to the version of rector; we cannot specify the version of rector without adding rector to composer.json.

Have you experienced any dependency conflicts with installing rector?

@MGatner

MGatner commented Sep 9, 2023

Copy link
Copy Markdown
Member

Nope! I bought into Bergmann's strong anti-dependency sentiment for static analysis when I first created this. I'm over it 😇 This is a good change.

@kenjiskenjis mentioned this pull request Sep 12, 2023
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datamwebdatamwebdatamweb approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees

No one assigned

Labels

github_actionsPull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@MGatner@datamweb