Uh oh!
There was an error while loading. Please reload this page.
chore: add no-merge-commits.yml - #764
Conversation
3e2d994 to
1464165Comparedatamweb
commented
Aug 18, 2023
@paulbalandan , why do we need this feature, just to keep clean history? Or does it have other benefits? |
paulbalandan
commented
Aug 18, 2023
Why added here? I saw you guys asking contributors not use merge commits in PRs so I thought why not automate that. Yes, to keep clean history of PR once merged to develop. You don't want to see the history of |
datamweb
commented
Aug 18, 2023
This strictness will be useful for the repo but annoying for the contributors. |
paulbalandan
commented
Aug 18, 2023
If it is annoying, why are you enforcing it then to contributors manually (saying "Please don't use git merge, use git rebase.")? Isn't that annoying as well? This is the behavior before and after: If you're not comfortable with this addition, please feel free to send a revert PR. |
paulbalandan
commented
Aug 18, 2023
Then make docs for it. I don't understand why you are making a fuss about this when this is already done in the past albeit manually. I just implemented an automated solution. |
kenjis
commented
Aug 18, 2023
There is already. I explained how to do: #789 (comment) |
kenjis
commented
Aug 18, 2023
@datamweb We added the Paul's check. But I do not expect every contributor could do But I do not expect all contributors cannot use |
https://github.com/marketplace/actions/no-merge-commits-action