feat: redirect after login to entrance url by mshannaq · Pull Request #789 · codeigniter4/shield

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

mshannaq · 2023-08-15T16:07:41Z

Redirect after login to entrance url
closes #722

datamweb · 2023-08-15T16:17:26Z

Thank you very much for your PR.

Please note that commit writing must be with the following description:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#committing

Please write unit test for PR:
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

kenjis · 2023-08-15T22:35:38Z

The develop branch has been updated and fixed the coding style check errors.
Please rebase to update your PR branch.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

into beforeLogginUrl

datamweb · 2023-08-17T14:42:53Z

@mshannaq Please do not use git merge.
Use git rebase to update the branch.
Using git merge caused the github action to fail:
https://github.com/codeigniter4/shield/actions/runs/5891110836/job/15977524828?pr=789

datamweb · 2023-08-18T15:57:37Z

It seems you have 2 ways to fix error Detect Merge Commits.

use git rebase -i
use git cherry-pick

I try to use git rebase -i to fix the Github Action:

git branch beforeLogginUrl.bk beforeLogginUrl

git rebase -i origin/beforeLogginUrl~5

After your above command, your editor will open as follows.

Now modify the items in the editor as follows. And after that save the file and close the editor:

Now wait a bit. If you are asked for a password, enter your password. Your editor will open again as follows:

You should edit the file as follows and then save it. After that, close the editor:

If you have done everything correctly, you should see the following message in your terminal.

git push -f origin beforeLogginUrl

The above method is called squash. After executing the commands, your 5 commits should become 1 commit with message feat: redirect after login to entrance url.

To be honest, these topics are complicated for me too, I hope you can handle it.

kenjis · 2023-08-18T19:52:19Z

@datamweb
How to git rebase is described here.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch

$ git log --oneline 8bf8c4f (HEAD -> beforeLogginUrl) feat: redirect after login to entrance url379a201 Merge branch 'beforeLogginUrl' of https://github.com/mshannaq/ci4-shield into beforeLogginUrl03f3a2c feat: redirect after login to entrance urlb099984 Merge branch 'codeigniter4:develop' into beforeLogginUrl78cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge89549c3 Merge pull request #782 from kenjis/update-RELEASE.md2d0ec09 Merge pull request #787 from datamweb/fix-style-code27b4323 Redirect after login to entrance url #722

Update your develop branch:

$ git fetch upstream
$ git switch develop
$ git merge upstream/develop
$ git push origin develop

Switch to the PR branch:

$ git switch beforeLogginUrlSwitched to branch 'beforeLogginUrl'

Do git rebase:

$ git rebase upstream/developSuccessfully rebased and updated refs/heads/beforeLogginUrl.

$ git log --oneline 0ace028 (HEAD -> beforeLogginUrl) feat: redirect after login to entrance urlac9173c feat: redirect after login to entrance url97d92be Redirect after login to entrance url #72278cac54 (upstream/develop, origin/develop, origin/HEAD, develop) Merge pull request #788 from codeigniter4/datamweb-add-status-badge

kenjis · 2023-08-18T19:58:48Z

@mshannaq After git rebase, there are three commits. But it seems there is no reason to be three commits. The commit messages are the same, and they are all for redirect after login to entrance url.

If you can, please squash them into one commit.

kenjis · 2023-08-18T20:07:37Z

 {
- $url = setting('Auth.redirects')['login'];
+ $session = session();
+ $url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];


Suggested change
$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

kenjis · 2023-08-18T20:07:49Z


+ if (! url_is('login')) {
+ $session = session();
+ $session->setTempdata('beforeLogginUrl', current_url(), 300);


Suggested change
$session->setTempdata('beforeLogginUrl', current_url(), 300);
$session->setTempdata('beforeLoginUrl', current_url(), 300);

kenjis · 2023-08-18T20:09:23Z

+ $result->assertRedirectTo('/login');
+ $this->assertNotEmpty($_SESSION['beforeLogginUrl']);
+ $this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);


All superglobals should be removed. So please use the Session class.
Suggested change
$result->assertRedirectTo('/login');
$this->assertNotEmpty($_SESSION['beforeLogginUrl']);
$this->assertSame(site_url('protected-route'), $_SESSION['beforeLogginUrl']);
$result->assertRedirectTo('/login');
$session = session();
$this->assertNotEmpty($session->get('beforeLogginUrl'));
$this->assertSame(site_url('protected-route'), $session->get('beforeLogginUrl'));

mshannaq · 2023-08-20T19:06:08Z

I created a new branch and apply the changes into as it more easy and then I submit a PR793

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

Redirect after login to entrance urlcodeigniter4#722
27b4323

datamweb changed the title ~~Redirect after login to entrance url #722~~feat: redirect after login to entrance urlAug 15, 2023

datamweb added enhancement New feature or request tests needed Pull requests that need tests labels Aug 15, 2023

mshannaqand others added 4 commits August 17, 2023 14:27

Merge branch 'codeigniter4:develop' into beforeLogginUrl
b099984

feat: redirect after login to entrance url
03f3a2c

Merge branch 'beforeLogginUrl' ofhttps://github.com/mshannaq/ci4-shield
379a201
into beforeLogginUrl

feat: redirect after login to entrance url
8bf8c4f

datamweb mentioned this pull request Aug 18, 2023
chore: add no-merge-commits.yml #764
Merged

kenjis reviewed Aug 18, 2023
View reviewed changes

mshannaq closed this Aug 20, 2023

mshannaq deleted the beforeLogginUrl branch August 20, 2023 18:39

This was referenced Aug 20, 2023
feat: redirect after login to entrance url #793
Merged
docs: Add @method for when() and whenNot() in models. codeigniter4/CodeIgniter4#7836
Merged

	$url = $session->getTempdata('beforeLogginUrl') ?? setting('Auth.redirects')['login'];
	$url = $session->getTempdata('beforeLoginUrl') ?? setting('Auth.redirects')['login'];

	$session->setTempdata('beforeLogginUrl', current_url(), 300);
	$session->setTempdata('beforeLoginUrl', current_url(), 300);

Uh oh!

Conversation

mshannaq commented Aug 15, 2023• edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datamweb commented Aug 15, 2023

Uh oh!

kenjis commented Aug 15, 2023

Uh oh!

datamweb commented Aug 17, 2023

Uh oh!

datamweb commented Aug 18, 2023

Uh oh!

kenjis commented Aug 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenjis commented Aug 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshannaq commented Aug 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mshannaq commented Aug 15, 2023• edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datamweb commented Aug 15, 2023

Uh oh!

kenjis commented Aug 15, 2023

Uh oh!

datamweb commented Aug 17, 2023

Uh oh!

datamweb commented Aug 18, 2023

Uh oh!

kenjis commented Aug 18, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kenjis commented Aug 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshannaq commented Aug 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mshannaq commented Aug 15, 2023• edited by kenjis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datamweb commented Aug 15, 2023

Uh oh!

kenjis commented Aug 15, 2023

Uh oh!

datamweb commented Aug 17, 2023

Uh oh!

datamweb commented Aug 18, 2023

mshannaq commented Aug 15, 2023•
edited by kenjis
Loading

kenjis commented Aug 18, 2023•
edited
Loading

mshannaq commented Aug 15, 2023•
edited by kenjis
Loading

kenjis commented Aug 18, 2023•
edited
Loading

mshannaq commented Aug 15, 2023•
edited by kenjis
Loading

kenjis commented Aug 18, 2023•
edited
Loading

mshannaq commented Aug 15, 2023•
edited by kenjis
Loading

kenjis commented Aug 18, 2023•
edited
Loading