Skip to content

fixed serialization issue (multiple backslash) - #327

Merged
phpnode merged 3 commits into
codemix:masterfrom
luigidellaquila:master
Jun 12, 2015
Merged

fixed serialization issue (multiple backslash)#327
phpnode merged 3 commits into
codemix:masterfrom
luigidellaquila:master

Conversation

@luigidellaquila

Copy link
Copy Markdown
Contributor

Fixed a serialization issue for fields that contain multiple backslash characters

@phpnode

phpnode commented Jun 12, 2015

Copy link
Copy Markdown
Member

@luigidellaquila thanks, but this bug has recurred a few times, mind adding a test for it?

@luigidellaquila

Copy link
Copy Markdown
Contributor Author

Hi @phpnode

no problem, I'm doing this right now.
Is the bug already tracked? Should I file a new issue for my specific test case?

Thanks

@phpnode

phpnode commented Jun 12, 2015

Copy link
Copy Markdown
Member

@luigidellaquila can't find any issues for it, but there's no need to create a new one, I just remember seeing this a few times before, e.g. at one point OrientDB would accept strings like http://foo.com/ correctly but not //foo.com/

@luigidellaquila

Copy link
Copy Markdown
Contributor Author

@phpnode too late ;-)
I just created an issue for this and provided a test case.
Anyway, the problem is with backslash at the end of a string, not with a slash.
eg.

insert into V set foo = "asdfasdf\\\\", bar = ">"

Thanks a lot!

Luigi

phpnode added a commit that referenced this pull request Jun 12, 2015
fixed serialization issue (multiple backslash)
@phpnode
phpnode merged commit 952e0ab into codemix:master Jun 12, 2015
@phpnode

phpnode commented Jun 12, 2015

Copy link
Copy Markdown
Member

@luigidellaquila thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants