Skip to content

fixed serialization issue (multiple backslash) #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phpnode merged 3 commits into from
Jun 12, 2015
Merged

fixed serialization issue (multiple backslash) #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b657083
fixed serializasion issue when a field value contains multiple backsl…
luigidellaquila Jun 12, 2015
ecb6205
providing test case for #328
luigidellaquila Jun 12, 2015
119fd51
just typos on a test case
luigidellaquila Jun 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/transport/binary/protocol28/serializer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function serializeDocument (document, isMap) {
function serializeValue (value) {
var type = typeof value;
if (type === 'string') {
return '"' + value.replace(/\\/, "\\\\").replace(/"/g, '\\"') + '"';
return '"' + value.replace(/\\/g, "\\\\").replace(/"/g, '\\"') + '"';
}
else if (type === 'number') {
return ~value.toString().indexOf('.') ? value + 'f' : value;
Expand Down
27 changes: 27 additions & 0 deletions test/bugs/328-wrong-backslash-quoting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
describe("Bug #328: wrong serialization of fields with multiple backslash characters", function () {
before(function () {
return CREATE_TEST_DB(this, 'testdb_bug_328')
.bind(this)
.then(function () {
return this.db.class.create('TestSerializeBackslash');
});
});
after(function () {
return DELETE_TEST_DB('testdb_bug_328');
});

it('should insert a document with correct quotes for backslashes', function () {
return this.db
.insert()
.into('TestSerializeBackslash')
.set({
foo: 'kratke, , nadherne, proste bozi, chjo som sa ostrihal :\\\\',
bar: '>'
})
.one()
.then(function (res) {
res.foo.should.equal('kratke, , nadherne, proste bozi, chjo som sa ostrihal :\\\\');
});
});

});