Skip to content

fix: fix PR preview delete - #110

Closed
35C4n0r wants to merge 1 commit into
coder:mainfrom
35C4n0r:fix-delete-preview
Closed

fix: fix PR preview delete#110
35C4n0r wants to merge 1 commit into
coder:mainfrom
35C4n0r:fix-delete-preview

Conversation

@35C4n0r

Copy link
Copy Markdown
Collaborator

No description provided.

@35C4n0r35C4n0r self-assigned this Oct 1, 2025
@35C4n0r35C4n0r changed the title feat: fix delete previewfix: fix PR preview deleteOct 1, 2025
@github-actions

Copy link
Copy Markdown

✅ Preview binaries are ready!

To test with modules: agentapi_version = "agentapi_110" or download from: https://github.com/coder/agentapi/releases/tag/agentapi_110

@matifalimatifali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need two separate workflows here?
Is this all to get the PR number in the closet PR event?

Comment on lines +20 to +26
- name: Download cleanup signal
uses: actions/download-artifact@v4
with:
name: cleanup-signal
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the significance of this artifact?

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnstcngh release create/delete/update commands don't work from a PR from a fork as the GITHUB_TOKEN doesn't have enough access.

eg: Check the second step here
https://github.com/coder/agentapi/actions/runs/18270399274/job/52011769517

That's why I had to break this into two parts (similar to the pr release preview).

So now, the signal is created when a PR is closed and then the actual release operations are done on the coder/agentapi repo.

@matifali

Copy link
Copy Markdown
Member

@35C4n0r is it still relavent?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@35C4n0r@matifali@johnstcn