Skip to content

fix: fix PR preview delete#110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
35C4n0r wants to merge 1 commit into from
Closed

fix: fix PR preview delete #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/pr-preview-cleanup-signal.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
name: PR Preview Cleanup Signal

on:
pull_request:
types: [closed]


jobs:
cleanup-signal:
name: Signal Cleanup
runs-on: ubuntu-latest
permissions:
contents: write

steps:
- name: Save PR number for cleanup
run: |
mkdir -p ./cleanup
echo ${{ github.event.pull_request.number }} > ./cleanup/number

- name: Upload cleanup signal
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: cleanup-signal
path: cleanup/
47 changes: 34 additions & 13 deletions .github/workflows/pr-preview-cleanup.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,42 @@
name: PR Preview Cleanup

on:
pull_request:
types: [closed]
workflow_run:
workflows: ["PR Preview Cleanup Signal"]
types:
- completed

permissions:
contents: write
contents: write
pull-requests: write

jobs:
cleanup:
name: Delete PR Release
runs-on: ubuntu-latest
cleanup:
name: Delete PR Release
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}

steps:
- name: Delete PR Release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RELEASE_TAG: 'agentapi_${{ github.event.pull_request.number }}'
run: |
gh release delete "$RELEASE_TAG" --cleanup-tag --yes --repo ${{ github.repository }} || true
steps:
- name: Download cleanup signal
uses: actions/download-artifact@v4
with:
name: cleanup-signal
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ github.event.workflow_run.id }}

Comment on lines +20 to +26

@johnstcnjohnstcnOct 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the significance of this artifact?

@35C4n0r35C4n0rOct 6, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnstcngh release create/delete/update commands don't work from a PR from a fork as the GITHUB_TOKEN doesn't have enough access.

eg: Check the second step here
https://github.com/coder/agentapi/actions/runs/18270399274/job/52011769517

That's why I had to break this into two parts (similar to the pr release preview).

So now, the signal is created when a PR is closed and then the actual release operations are done on the coder/agentapi repo.

- name: Read PR number
id: pr
run: echo "number=$(cat number)" >> "${GITHUB_OUTPUT}"

- name: Delete PR Release
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RELEASE_TAG: "agentapi_${{ steps.pr.outputs.number }}"
run: |
# Check if release exists and delete it
if gh release view "$RELEASE_TAG" --repo ${{ github.repository }} &>/dev/null; then
echo "Deleting release $RELEASE_TAG"
gh release delete "$RELEASE_TAG" --cleanup-tag --yes --repo ${{ github.repository }}
else
echo "Release $RELEASE_TAG does not exist, nothing to delete"
fi
Loading