Uh oh!
There was an error while loading. Please reload this page.
feat: user-mode docker - #192
Conversation
Signed-off-by: Hikari <enra@sayonika.moe>
kylecarbs
commented
Mar 14, 2019
Wonderful change. ping @nhooyr |
Uh oh!
There was an error while loading. Please reload this page.
coadler
left a comment
There was a problem hiding this comment.
I think this is a good change and should debate the semantics on an issue later. This seems to be the last step for code-server integration in Che so it'd be nice for people to be able to start using it.
The adduser portion doesn't look that bad to me though, although I know that's not the whole argument. It's minor enough we can reevaluate later
kylecarbs
commented
Mar 15, 2019
Once the conflicts are resolved I'm good to merge @sr229 |
sr229
commented
Mar 16, 2019
merge issues fixed, CI seems stuck but PR build reports fine |
I feel like this is worth mentioning, but I made my own changes to shift over to a non-root user that mimic the changes in this PR. The Dockerfile in question is here: https://gist.github.com/davefinster/39825c0fa7cf168b8114d24bd3b3df53 When I first deployed the container and everything worked except Workspace creation. The container was setup via Kube using these params: command: ["code-server"]args:
- --allow-http
- --no-auth
- --port=8440
- --data-dir=/home/coder/.code-server
- /home/coderworkingDir: /home/coderDespite that, I was getting file write errors (due to permissions - non-root user writing into /root so not surprising) whenever VS Code tried to anything Workspace related since it was always attempting to write into /root/.code-server/Workspaces/number/workspace.json regardless of what I did. I ended up having to add these lines to get it to work: mkdir -p /root/.code-server/Workspaces && \
chown -R 3000 /root/.code-server && \
chmod -R 777 /root/.code-server && \
chmod 755 /root |
kylecarbs
commented
Mar 19, 2019
@davefinster interesting. @sr229 have you experienced that with this dockerfile? |
sr229
commented
Mar 19, 2019
@davefinster@kylecarbs This is a mirror of my Dockerfile, particularly the Vanilla dockerfile. Every operation works, and you shouldn't be mounting on |
davefinster
commented
Mar 19, 2019
Ignore my comment - turns out it was due to a dirty workspace key in localstorage. |
im abusing the word slap today please help me
sr229
commented
Mar 27, 2019
Request for another review for merge @coadler@kylecarbs |
lsmoura
commented
Mar 28, 2019
@sr229 you need to merge master into your branch again. 😓 |
sr229
commented
Mar 29, 2019
Should be ready to merge now. |
Describe in detail the problem you had and how this PR fixes it
Prior to discussion to #65, this runs all file operations in the user
coderin container along with some refactoring of the Dockerfile to make it easier to read.Is there an open issue you can link to?
This resolves#65. This will be blocked until general consensus that this merit as a merge.