Uh oh!
There was an error while loading. Please reload this page.
Significantly improve the Dockerfile - #433
Conversation
54cf52c to
cae2b3fComparenhooyr
commented
Apr 4, 2019
Will need to update the README.md with a command to mount into |
nhooyr
commented
Apr 4, 2019
Unfortunately, dumb-init is not sending signals properly when using the |
nhooyr
commented
Apr 4, 2019
Nvm, got it working. See https://stackoverflow.com/questions/41097652/how-to-fix-ctrlc-inside-a-docker-container |
Signed-off-by: Hikari <enra@sayonika.moe>
im abusing the word slap today please help me
RichardMcSorley
commented
Apr 5, 2019
@nhooyr Great you got it working. |
frol
commented
Apr 5, 2019
Passwordless sudo is like an always-open door (in the real world). There is definitely a room for improvement. |
sr229
commented
Apr 5, 2019
@frol its still teaching basic practice anyways, so I don't think primarily its open door especially if its just a container (and the fact GCP practices this as well due to the fact - you know, they're SSH keys only by default). |
nhooyr
commented
Apr 5, 2019
We could prompt users to set a password on startup later @frol but for now this is a simple improvement. |
sr229
commented
Apr 5, 2019
I vote against that IMHO, I don't think we need to support that kind of use case especially in Docker. The user should do it themselves if they really want to. We just provide a sane default for them. |
nhooyr
commented
Apr 5, 2019
Asking for a password is a safe default and the common use case. What we're providing is the exception. |
Significantly improve the Dockerfile
closesSwitch to an LTS version of Ubuntu (18.04) for the Dockerfile #404
Thanks to @RichardMcSorley and @sr229
Describe in detail the problem you had and how this PR fixes it
Is there an open issue you can link to?