Uh oh!
There was an error while loading. Please reload this page.
feat: refactor npm to pnpm - #613
Conversation
✅ Heimdall Review Status
|
| node --version | ||
| npm list @coinbase/agentkit | ||
| npm list @coinbase/agentkit-langchain # if using LangChain extension | ||
| pnpm -r list @coinbase/agentkit |
There was a problem hiding this comment.
npm list is recursive by default, while pnpm list is not. Hence the added -r flag to recurse
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup pnpm |
There was a problem hiding this comment.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| packages: | ||
| - "agentkit" | ||
| - "create-onchain-agent" | ||
| - "create-onchain-agent/templates/*" |
There was a problem hiding this comment.
I figured a minor devx improvement could be made here, so contributors do not need to remember to add to this list. However, I am open to reversing this back to individually listing each package if we want to be explicit
There was a problem hiding this comment.
(For reference, this list used to live in package.json)
| "outputs": [ | ||
| "dist/**", | ||
| ".next/**", | ||
| "!.next/cache/**", |
There was a problem hiding this comment.
Fixes warnings from templates that get added to the workspace, but whose build process differs from AgentKit traditionally builds to /dist.
Specifically, the CLI templates for Next and Mcp Server require this to get rid of the cli warnings on build
There was a problem hiding this comment.
Should we even be building the templates as part of our normal build process? If/when the templates incorporate nunjucks, the builds will stop working
There was a problem hiding this comment.
(not blocking, can be a follow-up / still up for debate)
There was a problem hiding this comment.
True, right now we're just building the projects that don't use nunjucks. Next was not affected by that PR, I just used it for the new generate commands.
I am fine with straight up ignoring them in a follow
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6b86cef to
c0d4607CompareUh oh!
There was an error while loading. Please reload this page.
e403380 to
c6b4464CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Description
pnpm is a mostly-drop in replacement for npm, focused on performance.
Some benefits include:
This PR refactors our turbo monorepo to use pnpm instead of npm. This requires:
workspace:*syntax, allowing pnpm to resolve versions for us duringpnpm publish, removing bump step during releasesChecklist
A couple of things to include in your PR for completeness: