Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 799
feat: refactor npm to pnpm#613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
49e8949
feat: refactor npm to pnpm
CarsonRoscoe 195480f
chore: use pnpm/action-setup with sha pin
CarsonRoscoe 5c54abf
chore: updated changelog
CarsonRoscoe f9e6b9a
fix: publish_nightly to use pnpm
CarsonRoscoe ac77ce9
chore: updated readme to include pnpm installation instructions
CarsonRoscoe 1cb991c
chore: removed test:dry-run commands
CarsonRoscoe 8b2d786
chore: reverted user-facing comments to reference npm rather than pnpm
CarsonRoscoe 0e06970
chore: removed changelog entry
CarsonRoscoe 64920f2
feat: link subprojects dependening on each other via workspace:* pattern
CarsonRoscoe 501b90a
chore: changed recommended node manager from nvm to fnm
CarsonRoscoe 3e4fb70
chore: removed .npmrc and added missing dependencies
CarsonRoscoe 4379b47
chore: refactored npx jest to pnpm jest
CarsonRoscoe 862b506
fix: dependencies in examples
CarsonRoscoe 9144952
fix: bs58 dependency issue
CarsonRoscoe 446408f
feat: updated bs58 dependency to ^4.0.1
CarsonRoscoe c6b4464
fix: jest hoisting
CarsonRoscoe d77b7ea
fix: unit tests
CarsonRoscoe 113cfb6
chore: npm to pnpm migration note for contributors
CarsonRoscoe 5df686a
fix: pr feedback
CarsonRoscoe f07451a
chore: format
CarsonRoscoe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -40,13 +40,17 @@ jobs: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda | ||
| with: | ||
| version: 10 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "18" | ||
| cache: "npm" | ||
| cache: "pnpm" | ||
| cache-dependency-path: ./typescript | ||
| - name: Ensure formatting | ||
| working-directory: ./typescript | ||
| run: | | ||
| npm ci | ||
| npm run format:check | ||
| pnpm install --frozen-lockfile | ||
CarsonRoscoe marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| pnpm run format:check | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm/action-setup@v4to setup pnpm before runningactions/setup-node@v4