Uh oh!
There was an error while loading. Please reload this page.
stats/v1: export per-cgroup stats - #100
Merged
Merged
Conversation
The cgroupstats provides information from taskstats which help us to know how `busy` tasks in one cgroup are right now. With Metric API in shim, it can enhance monitor capability. For more information: * https://github.com/torvalds/linux/blob/master/include/uapi/linux/cgroupstats.h * https://www.kernel.org/doc/Documentation/accounting/cgroupstats.txt * https://www.kernel.org/doc/Documentation/accounting/taskstats.txt Signed-off-by: Wei Fu <fuweid89@gmail.com>
Codecov Report
@@ Coverage Diff @@## master #100 +/- ##
=======================================
Coverage 45.42% 45.42% =======================================
Files 23 23 Lines 1638 1638 =======================================
Hits 744 744 Misses 768 768 Partials 126 126Continue to review full report at Codecov.
|
crosbymichael
commented
Oct 9, 2019
Member
So these stats are provided via a netlink socket? |
fuweid
commented
Oct 10, 2019
MemberAuthor
Yes. It seems efficient I think. |
crosbymichael
commented
Oct 10, 2019
Member
Where is the implementation going to come from? the Shims? |
fuweid
commented
Oct 11, 2019
MemberAuthor
Yes. It is for kata container. We put the collector in the agent. It will export the data through Mertic Shim API. |
We decide to use metric-server get load information instead of using cadvisor(we make runc and kata provide load information, and passed by shim metric interface). So add a interface in containerd/cgroup libbrary. |
crosbymichael
commented
Oct 11, 2019
Member
LGTM |
1 task
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Oct 31, 2019
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 31, 2019
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 27552ceb15bca544820229e574427d4c1d6ef585 Component: engine
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Dec 3, 2019
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27552ce) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 23, 2020
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27552ceb15bca544820229e574427d4c1d6ef585) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 9ab162a73ac9e133a21cffbadd3339cbb5213939 Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cgroupstats provides information from taskstats which help us to
know how
busytasks in one cgroup are right now. With Metric API inshim, it can enhance monitor capability.
For more information:
Signed-off-by: Wei Fu fuweid89@gmail.com