Uh oh!
There was an error while loading. Please reload this page.
Move metrics proto package to stats/v1 - #96
Merged
Conversation
crosbymichael
commented
Sep 18, 2019
Member
change looks good but tests need updated |
jterry75
commented
Sep 18, 2019
ContributorAuthor
Oops. I thought for sure I ran these. |
In order for projects to link the metrics.proto file with go modules it is required to have a go import. This creates a problem because the cgroups package is not platform independent although its types are. Moving the types to a sperate package allows consumption of the types regardless of platform. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Codecov Report
@@ Coverage Diff @@## master #96 +/- ##
===========================================
+ Coverage 14.05% 41.76% +27.71%
===========================================
Files 24 23 -1 Lines 4911 1616 -3295 ===========================================
- Hits 690 675 -15 + Misses 4097 817 -3280
Partials 124 124
Continue to review full report at Codecov.
|
crosbymichael
commented
Sep 18, 2019
Member
LGTM |
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Oct 31, 2019
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Oct 31, 2019
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 27552ceb15bca544820229e574427d4c1d6ef585 Component: engine
thaJeztah added a commit
to thaJeztah/docker
that referenced
this pull request
Dec 3, 2019
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27552ce) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Jan 23, 2020
full diff: containerd/cgroups@c4b9ac5...5fbad35 - containerd/cgroups#82 Add go module support - containerd/cgroups#96 Move metrics proto package to stats/v1 - containerd/cgroups#97 Allow overriding the default /proc folder in blkioController - containerd/cgroups#98 Allows ignoring memory modules - containerd/cgroups#99 Add Go 1.13 to Travis - containerd/cgroups#100 stats/v1: export per-cgroup stats Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 27552ceb15bca544820229e574427d4c1d6ef585) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 9ab162a73ac9e133a21cffbadd3339cbb5213939 Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for projects to link the metrics.proto file with go modules it
is required to have a go import. This creates a problem because the
cgroups package is not platform independent although its types are.
Moving the types to a sperate package allows consumption of the types
regardless of platform.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com