Skip to content

Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values and handling empty server command inputs. - #74

Merged
SakshiKoli-CS merged 16 commits into
stagingfrom
development
Dec 10, 2025
Merged

Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values and handling empty server command inputs.#74
SakshiKoli-CS merged 16 commits into
stagingfrom
development

Conversation

@SakshiKoli-CS

Copy link
Copy Markdown
Contributor

fix: skip environment variables option with --variable-type flag
fix: suppress error message in non-development environments
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to accept multiple values
fix: handle empty server command input properly

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements multiple fixes to improve the launch command functionality, including environment variable handling, Apollo Client warning suppression, and server command input validation. The changes upgrade Apollo Client to version 3.14.0 and add support for multiple variable-type flags, URL-formatted environment values, and proper handling of empty server command inputs.

Key Changes:

  • Upgraded Apollo Client from 3.11.8 to 3.14.0 with console patching to suppress Apollo warnings in production
  • Enhanced environment variable parsing to support URL-formatted values (e.g., https://api.example.com)
  • Modified --variable-type flag to accept multiple values and properly convert string to array format
  • Improved server command handling to conditionally include the field only when non-empty

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
src/util/apollo-client.tsAdded console patching to suppress Apollo-specific errors/warnings in non-development environments and exported isNotDevelopment flag
test/unit/util/apollo-client.test.tsAdded Mocha/Chai tests for console suppression behavior in development vs non-development environments
src/util/logs-polling-utilities.tsAdded withDeprecationsDisabled helper method to wrap Apollo Client queries and suppress deprecation warnings
src/adapters/base-class.tsAdded parseEnvVariablesString method to parse environment variables with colon-containing values and convert variableType string to array
src/adapters/base-class.test.tsAdded comprehensive tests for string-to-array conversion, multiple variable type selection, and URL parsing
src/commands/launch/index.tsUpdated variable-type flag to support multiple values with multiple: true option
src/adapters/github.tsModified server command handling to only include field when non-empty and updated variableType assignment
src/adapters/github.test.tsAdded comprehensive tests for server command prompt behavior and deployment flow
src/adapters/file-upload.tsModified server command handling to only include field when non-empty and updated variableType assignment
src/adapters/file-upload.test.tsAdded comprehensive tests for server command prompt behavior and file upload flow
package.jsonUpgraded @apollo/client dependency from ^3.11.8 to ^3.14.0
package-lock.jsonUpdated lock file with Apollo Client 3.14.0 dependencies
AGENTS.mdAdded new testing guidelines document for AI agents
.github/CODEOWNERSUpdated code ownership rules to be more granular
.github/workflows/secrets-scan.ymlRemoved secrets scanning workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadsrc/adapters/base-class.test.ts
Comment threadsrc/util/logs-polling-utilities.ts
Comment threadsrc/adapters/github.ts
Comment threadsrc/adapters/file-upload.ts
Comment threadtest/unit/util/apollo-client.test.ts
Comment threadAGENTS.md
@SakshiKoli-CS
SakshiKoli-CS merged commit f5d4d26 into stagingDec 10, 2025
12 of 13 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@SakshiKoli-CS@ron766-CS@Chhavi-Mandowara@dhruvparekh12@Aravind-Kumar-cstk@Harshi-Shah-CS