Fix: Panel Icon Padding Issues

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.

[SuiziM]

Summary

This PR fixes uneven margins in the panel caused by style class application and element ordering, which led to inconsistent spacing at the edges of the panel button.

Old situation

Style classes and ordering caused uneven margins on both ends:

[ 8px [ICON] VAR: px + 0px [LABEL] 3px + 8 px [ICON] VAR px + 0px [LABEL] 3px ]
↑ ↑

hide-icons only hid the glyph, not the StIcon itself, so empty icons still contributed spacing:

[ 8px [] VAR px + 0px [LABEL] 3px + 8 px [] VAR px + 0px [LABEL] 3px ]
↑ ↑ ↑ 

Note 1: VAR depends on icon type and was hardcoded in CSS to even out spacing since StIcons are square while glyphs are not.
Note 2: There are also 9px of extra "padding" on each side from the pill button’s rounded edges.

New situation

[ 3px [ [ICON] VAR px [LABEL] ] 11px [ [ICON] VAR px [LABEL] ] 3px ]
↑ ↑ ↑ padding spacing padding 

and with hide-icons:

[ 3px [ [LABEL] ] 11px [ [LABEL] ] 11px [ [LABEL] ] 3px ]
↑ ↑ ↑ ↑
padding spacing spacing padding 

Changes Made

• BoxLayout per item:_createHotItems now puts label + optional icon (depending on hide-icons) in a St.BoxLayout, tracked in _hotItems.

  • Outer margins are controlled via padding on _menuLayout, spacing between items via spacing.
  • Icon–label gaps still use variable right margins to equalize glyph width differences, optionally with spacing of the item BoxLayout

• No empty St.Icons: If hide-icons is set, StIcons aren’t created (except _default_icon).

• Simplified removal_removeHotIcon(s) and _removeHotLabel(s) are replaced with _removeHotItem(s) , since BoxLayout manages its children. _hotIcons no longer needed.

• CSS updates: New classes .vitals-panel-menu and .vitals-panel-item for spacing/margins . Icon left margins set to 0.

• Minor startup fix: Fixed "called on [...] not in the stage" warning by switching from .width to .get_clutter_text().width in _createHotMenuIcons.

• System sensors trailing whitespace or missing units: Removed trailing whitespace from System sensor "Last XX min" values. Alternative would be to add a unit.

Testing

• No startup errors
• No errors during adding/removing items or when changing settings
• Icons align consistently with/without icons, and with/without fixed width.

Screenshots/Visual Changes

Before(bottom) and after(top) without icons:

Before(bottom) and after(top) with icons:

[corecoding]

Thank you! This is the most thorough and well documented pull requests that I've seen. I love seeing the images with the ruler lines showing your changes in action. Code cleanup is icing on the cake.

I have merged your changes into develop. They are working fine for me, but I want to give others time to test just in case. But I can confirm that I saw no warnings in logs (messages or journalctl -f) when adding/removing sensors, changing hide/show icons, etc.