Rewrote http.py to be faster - #68
Conversation
This change mirrors PR coreruleset#68
This change mirrors PR coreruleset#68
fzipi
left a comment
There was a problem hiding this comment.
Hmmm...
- requirements.txt updates should be in the dependency updates only.
- same with the test updates, should be in the tests only
|
I did that so the PR checks would run through and to show, that the change doesn't affect the tests. Do you still want me to change it? |
|
Are the tests failing when upgrading dependencies? |
|
Yes, partly because the domains used in the tests are unreliable. |
|
Well, then we should change the description on this PR to match whatever is doing. Also, if someone needs to revert it will erase both the http.py rewriting AND the tests update. I think that the easiest way to solve this is to create a new PR for updating the tests and the reason of reliability. We merge that one. Then rebase this one so it doesn't update tests also. We merge this one. Then rebase the following and keep going :) |
|
That PR already exists :) Your point about reverting is a good one. I'll update the PR's and indicate the proper order in which to review them. |
…eouts Split from PR coreruleset#66, part 1
495c16e to
5509b0e
Compare
|
Merging. |
…, mainly by using select() instead of timeouts
Split from PR #66, part 1