Skip to content

[LWG motion 25] P1383R2 More constexpr for cmath and complex - #6343

Merged
tkoeppe merged 2 commits into
mainfrom
motions-2023-06-lwg-25
Jul 21, 2023
Merged

tkoeppe merged 2 commits into
mainfrom
motions-2023-06-lwg-25

Conversation

@burblebee

@burblebee burblebee commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

@burblebee
burblebee marked this pull request as ready for review June 23, 2023 00:07

@JohelEGP JohelEGP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensmaurer jensmaurer added this to the post-2023-06 milestone Jun 27, 2023
@PJBoy

PJBoy commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

No feature test macro?

@JohelEGP

Copy link
Copy Markdown
Contributor

Looks like __cpp_lib_constexpr_cmath wasn't bumped by the paper.

@PJBoy

PJBoy commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

Shall we let burblebee commit a bump as part of this PR or should I raise a new issue?

@jwakely

jwakely commented Jun 28, 2023

Copy link
Copy Markdown
Member

LWG motion 5 was missing a macro bump too

@jensmaurer

Copy link
Copy Markdown
Member

@burblebee , please bump __cpp_lib_constexpr_cmath in a separate commit of this pull request.

@tkoeppe
tkoeppe force-pushed the motions-2023-06-lwg-25 branch from 1d88b30 to 4fdc6e7 Compare July 21, 2023 20:31
@tkoeppe

tkoeppe commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Feature test macro bumped, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2023-06 LWG Motion 25] P1383R2 More constexpr for cmath and complex P1383 R2 More constexpr for cmath and complex

6 participants