fixed #13721 - Add support for Visual Studio 2026 .slnx project files

[IOBYTE]

No description provided.

[IOBYTE]

The selfcheck fails because of unused functions that have nothing to do with this PR. There appear to be suppressions for these errors but I don't know where they come from or how to fix them.

[chrchr-github]

The suppressions seem to come from here: https://github.com/danmar/cppcheck/blob/5bec5624f677636d38803d3a9fc152bcc5923fb3/.github/workflows/selfcheck.yml#L124

Not sure why we keep those functions around, if they are really unused. @firewave

[danmar]

I don't see any test. So well some basic test would be nice..

[chrchr-github]

The suppressions seem to come from here:

https://github.com/danmar/cppcheck/blob/5bec5624f677636d38803d3a9fc152bcc5923fb3/.github/workflows/selfcheck.yml#L124

Not sure why we keep those functions around, if they are really unused.

The functions are used by the GUI.

[IOBYTE]

I tried adding slnx to the first test in test/cli/project_test.py and I get this:

Bob@DESKTOP-3DNJ0T8 MINGW64 ~/forks/cppcheck/test/cli (main)
$ python -m pytest project_test.py
============================================================================= test session starts =============================================================================
platform win32 -- Python 3.13.0, pytest-9.0.2, pluggy-1.6.0
rootdir: C:\Users\Bob\forks\cppcheck\test\cli
collected 21 items
project_test.py ...........F......... [100%]
================================================================================== FAILURES ===================================================================================
_______________________________________________________________________ test_json_entry_file_not_found ________________________________________________________________________
tmpdir = local('C:\\Users\\Bob\\AppData\\Local\\Temp\\pytest-of-Bob\\pytest-16\\test_json_entry_file_not_found0')
def test_json_entry_file_not_found(tmpdir):
compilation_db = [
{"directory": str(tmpdir),
"command": "c++ -o bug1.o -c bug1.cpp",
"file": "bug1.cpp",
"output": "bug1.o"}
]
project_file = os.path.join(tmpdir, "file.json")
missing_file = os.path.join(tmpdir, "bug1.cpp")
missing_file_posix = missing_file
if sys.platform == "win32":
missing_file_posix = missing_file_posix.replace('\\', '/')
with open(project_file, 'w') as f:
f.write(json.dumps(compilation_db))
ret, _, stderr = cppcheck([
'--template=simple',
"--project=" + str(project_file)
])
> assert 0 == ret
E assert 0 == 1
project_test.py:66: AssertionError
---------------------------------------------------------------------------- Captured stdout call -----------------------------------------------------------------------------
using 'C:\Users\Bob\forks\cppcheck\test\cli\cppcheck.exe'
=========================================================================== short test summary info ===========================================================================
FAILED project_test.py::test_json_entry_file_not_found - assert 0 == 1
======================================================================== 1 failed, 20 passed in 0.28s =========================================================================

Is this the test you are referring to? Is this the proper way to run this test? Are these tests run by CI? Should I be looking elsewhere?

My original PR added test/cli/helloworld2 but it was rejected because it duplicated 2 files. The current helloworld test only tests cppcheck gui projects with .sln project files. It should also check .vcxproj files but doesn't. .slnx files should also be added but these changes would require changes to helloworld_test.py and I don't know python. There are probably other tests that would need changes.

[IOBYTE]

Hopefully this is enough tests.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[IOBYTE]

I just noticed something interesting. Visual Studio created slnx files do not have the xml version on the first line but cmake generated files do. Visual Studio doesn't seem to care.

[firewave]

I gave it a quick look and it seems okay but I can't really hold a thought right now so I will give it a closer look later.

I just noticed something interesting. Visual Studio created slnx files do not have the xml version on the first line but cmake generated files do. Visual Studio doesn't seem to care.

The XML header is completely optional.

But we need to be able to handle BOMs.

[firewave]

But we need to be able to handle BOMs.

If we currently do not at all then that should be a follow-up with a separate ticket.

[firewave]

The functions are used by the GUI.

Yes, that is rather awkward and I thought it is okay for the time being. But then we started changing the project import any other week.

Still need to give the unusedFunction stuff in the CI a look. Some stuff slipped through because parts of it are disabled.

[ShadowIce]

I think this is skipping projects in folders. At least that's what I'm seeing here.

[IOBYTE]

Can you try this patch?

slnxfix.patch

[IOBYTE]

There is also a pull request here: #8681

[IOBYTE]

There is a ticket for the folder problem here: https://trac.cppcheck.net/ticket/14880

[ShadowIce]

I did a quick test of the PR with my solution and it seems to work.