Skip to content

Fix #14880 add support for Folders in slnx project file and skip non C++ projects - #8681

Merged
ludviggunne merged 14 commits into
cppcheck-opensource:mainfrom
IOBYTE:main
Jul 16, 2026
Merged

Fix #14880 add support for Folders in slnx project file and skip non C++ projects#8681
ludviggunne merged 14 commits into
cppcheck-opensource:mainfrom
IOBYTE:main

Conversation

@IOBYTE

@IOBYTEIOBYTE commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@IOBYTEIOBYTE mentioned this pull request Jul 1, 2026
Merged
@IOBYTEIOBYTE changed the title WIP add support for Folders in slnx project file and skip non C++ projectsadd support for Folders in slnx project file and skip non C++ projectsJul 2, 2026
@IOBYTE

IOBYTE commented Jul 2, 2026

Copy link
Copy Markdown
CollaboratorAuthor

this should be ready to go now

@IOBYTEIOBYTE changed the title add support for Folders in slnx project file and skip non C++ projectsFix #14880 add support for Folders in slnx project file and skip non C++ projectsJul 2, 2026
danmar
danmar previously approved these changes Jul 9, 2026
View reviewed changes
@danmar

danmar commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Sorry for slow review. I approve this. However there is a conflict in selfcheck.yml. If you fix that then feel free to merge.

@IOBYTE

IOBYTE commented Jul 9, 2026

Copy link
Copy Markdown
CollaboratorAuthor

I think I fixed the conflict but I can't figure out how to make github happy.

These hardcoded file and line numbers are a constant problem.

danmar
danmar previously approved these changes Jul 11, 2026
View reviewed changes
@danmar

danmar commented Jul 11, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

These hardcoded file and line numbers are a constant problem.

I agree, if we would implement a proper "cppcheck warning hash" similar in spirit to coveritys CID then we could suppress that instead.
Such hash would make our sarif output more proper also.

@danmar

danmar commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

I agree, if we would implement a proper "cppcheck warning hash" similar in spirit to coveritys CID then we could suppress that instead.

it should be possible to suppress unusedFunction warnings using the symbolName instead.

@danmar

danmar commented Jul 11, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

I made this PR #8714 to make the suppressions more flexible please feel free to review it.

@IOBYTE

IOBYTE commented Jul 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Can this be committed now?

@IOBYTE

IOBYTE commented Jul 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

I didn't notice your changes and may have discarded them while trying to resolve the conflict.

@ludviggunne
ludviggunne merged commit d32c01d into cppcheck-opensource:mainJul 16, 2026
70 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjakobssonwjakobssonwjakobsson approved these changes
@ludviggunneludviggunneludviggunne approved these changes
@danmardanmardanmar left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IOBYTE@danmar@wjakobsson@ludviggunne