Skip to content

refs #352 - generate output error on unknown DUI::std value - #312

Merged
danmar merged 1 commit into
cppcheck-opensource:masterfrom
firewave:unk-std
May 22, 2024
Merged

refs #352 - generate output error on unknown DUI::std value#312
danmar merged 1 commit into
cppcheck-opensource:masterfrom
firewave:unk-std

Conversation

@firewave

@firewavefirewave commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

If the value is unknown we are silently setting an invalid/unexcepted value for the predefined macros which might lead to other issues.

danmar
danmar reviewed Sep 11, 2023
View reviewed changes
Comment threadsimplecpp.cpp Outdated
@danmar

danmar commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

I guess a simplecpp issue wouldn't hurt also

@firewave
firewave marked this pull request as draft September 11, 2023 18:11
@firewave

firewave commented Sep 11, 2023

Copy link
Copy Markdown
CollaboratorAuthor

I guess a simplecpp issue wouldn't hurt also

Good point. Tickets for behavior changes.

@firewave

firewave commented Apr 24, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I adjusted the code so it uses the OutputList instead of throwing an exception.

Will file a ticket about this later.

@firewave
firewaveforce-pushed the unk-std branch 2 times, most recently from 9e41599 to ffba6e5CompareApril 24, 2024 18:52
@firewavefirewave mentioned this pull request May 3, 2024
Merged
@firewavefirewave changed the title bail out on unknown DUI::std valuerefs #352 - bail out on unknown DUI::std valueMay 6, 2024
@firewave

firewave commented May 6, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Will file a ticket about this later.

Done.

@firewave
firewave marked this pull request as ready for review May 6, 2024 14:33
danmar
danmar approved these changes May 21, 2024
View reviewed changes

@danmardanmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should I merge?

@firewave

firewave commented May 21, 2024

Copy link
Copy Markdown
CollaboratorAuthor

I thought we wanted to make a release with the current state first so we can get this repo and Cppcheck in sync again.

Afterwards feel free to merge anything I made ready for review and you approve of.

@firewavefirewave changed the title refs #352 - bail out on unknown DUI::std valuerefs #352 - generate output error on unknown DUI::std valueMay 21, 2024
@danmar

danmar commented May 22, 2024

Copy link
Copy Markdown
Collaborator

I thought we wanted to make a release with the current state first so we can get this repo and Cppcheck in sync again.
Afterwards feel free to merge anything I made ready for review and you approve of.

Sorry.. I have tagged 1.1.3 now. I tagged the old commit e040047

Please feel free to sync cppcheck.

@danmar
danmar merged commit 59f376c into cppcheck-opensource:masterMay 22, 2024
@firewave
firewave deleted the unk-std branch May 22, 2024 09:02
@firewave

firewave commented May 22, 2024

Copy link
Copy Markdown
CollaboratorAuthor

@danmar I changed the title of the PR because we do not actually bail out anymore. Strangely your merge still had the old title. I have no idea how this is even possible!?

@firewavefirewave mentioned this pull request May 22, 2024
Closed
@firewave

firewave commented May 22, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Actually it was merge with the original title from when I created this PR. I changed the title multiple times.

I have no seen this in the Cppcheck repo so far but there I usually merge the PRs myself.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmardanmardanmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave@danmar