Uh oh!
There was an error while loading. Please reload this page.
made it possible to create a TokenList from a buffer - #347
Conversation
firewave
commented
Mar 27, 2024
Still need to integrate/test it with #261 to make sure it does not introduce any issues. It is already actively used by |
firewave
commented
Mar 28, 2024
Some tests are still failing - will investigate. |
firewave
commented
Mar 28, 2024
The tests failing are the ones with binary characters in the string. We need to add an additional |
StdStringStream which reads from a std::stringTokenList from a abufferTokenList from a abufferTokenList from a bufferfirewave
commented
Mar 29, 2024
I changed it from a The tests pass but it produces valgrind failures in #261. |
firewave
commented
Mar 29, 2024
The issue has been fixed - see https://github.com/danmar/simplecpp/actions/runs/8484373804/job/23247192053?pr=261. |
TokenList from a bufferTokenList from a bufferfirewave
commented
Apr 30, 2024
I will provide a downstream PR which shows this is working within Cppcheck. We should also do the (planned) release before merging this. |
danmar
commented
May 3, 2024
@firewave would you like that I release simplecpp now or do you have some more fixes..? |
firewave
commented
May 3, 2024
| } | ||
| virtual int get() OVERRIDE { | ||
| if (pos >= size) |
There was a problem hiding this comment.
These checks are still a hot spot. No idea if there is a way to implement this in a more performant way.
firewave
commented
May 3, 2024
Here is the downstream PR using char buffers instead of streams: cppcheck-opensource/cppcheck#6379. |
firewave
commented
May 16, 2024
Ready for review since the downstream PR passes all tests. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
@firewave you should have gotten an invite for this project. I hope you can merge.. |
firewave
commented
May 23, 2024
@danmar Thanks. |
No description provided.