Skip to content

Fix MWC: fix global chain type race and use auth for mwc713.mwc.mw - #1271

Merged
julian-CStack merged 21 commits into
stagingfrom
fix/mwc
May 15, 2026
Merged

Fix MWC: fix global chain type race and use auth for mwc713.mwc.mw#1271
julian-CStack merged 21 commits into
stagingfrom
fix/mwc

Conversation

@sneurlax

@sneurlaxsneurlax commented Mar 3, 2026

Copy link
Copy Markdown
Member

2 fixes in one, one which fixes syncing and another which fixes a crash bug

Comment threadlib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated

@danrmillerdanrmiller left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on linux.

@codecov-commenter

codecov-commenter commented Apr 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.25000% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.93%. Comparing base (cf7251b) to head (e99bbc0).
⚠️ Report is 1 commits behind head on staging.

Files with missing linesPatch %Lines
...b/wallets/wallet/impl/mimblewimblecoin_wallet.dart0.00%49 Missing ⚠️
...gs_view/manage_nodes_views/add_edit_node_view.dart0.00%37 Missing ⚠️
lib/utilities/test_mwcmqs_connection.dart0.00%3 Missing ⚠️
lib/models/type_adaptors/node_model.g.dart80.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## staging #1271 +/- ##
========================================
Coverage 4.93% 4.93% ========================================
Files 1064 1064 Lines 107980 108016 +36 ========================================
+ Hits 5328 5334 +6 - Misses 102652 102682 +30 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

danrmiller
danrmiller previously approved these changes Apr 26, 2026

@danrmillerdanrmiller left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this as it improves the current state of the app, mwc will now work with this merged.

Comment threadlib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
Comment threadlib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
Comment threadlib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
@sneurlax
sneurlax marked this pull request as draft April 27, 2026 00:41
@sneurlaxsneurlax mentioned this pull request Apr 27, 2026
@sneurlax
sneurlax marked this pull request as ready for review April 27, 2026 00:48
@sneurlax

Copy link
Copy Markdown
MemberAuthor

Closes #1303 now too

`dart format $(git diff --name-only origin/staging...HEAD | grep '\.dart$')`
@sneurlax
sneurlax marked this pull request as draft April 27, 2026 02:29
@sneurlax

sneurlax commented Apr 27, 2026

Copy link
Copy Markdown
MemberAuthor

Have to recheck that

  • users can change the password in settings if mwc changes the password on their node

@sneurlax
sneurlax marked this pull request as ready for review May 13, 2026 23:20
Comment threadlib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
Comment threadlib/wallets/wallet/impl/mimblewimblecoin_wallet.dart Outdated
@julian-CStack
julian-CStack merged commit 037e13f into stagingMay 15, 2026
3 checks passed
@sneurlax

Copy link
Copy Markdown
MemberAuthor

followup comment: "merged. I did notice that the wallet handle var was directly accessed in places vs being ensureOpened but I think that is due to checks if the wallet is not open which should be fine as it replaces what I think was current functionality anyways. May be something to look into in the future to see if it could be hanlded a bit differently/safer"

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sneurlax@codecov-commenter@danrmiller@julian-CStack