Uh oh!
There was an error while loading. Please reload this page.
Fix MWC: fix global chain type race and use auth for mwc713.mwc.mw - #1271
Conversation
Uh oh!
There was an error while loading. Please reload this page.
danrmiller
left a comment
There was a problem hiding this comment.
LGTM. Tested on linux.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## staging #1271 +/- ##
========================================
Coverage 4.93% 4.93% ========================================
Files 1064 1064 Lines 107980 108016 +36 ========================================
+ Hits 5328 5334 +6 - Misses 102652 102682 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danrmiller
left a comment
There was a problem hiding this comment.
I'm approving this as it improves the current state of the app, mwc will now work with this merged.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sneurlax
commented
Apr 27, 2026
Closes #1303 now too |
`dart format $(git diff --name-only origin/staging...HEAD | grep '\.dart$')`
Have to recheck that
|
chore: dart format fix/mwc
diag(mwc): panic hook, listener fallback, and scanOutputs catch_unwind
chore(mwc): trim comments around wallet-handle refactor
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sneurlax
commented
May 15, 2026
followup comment: "merged. I did notice that the wallet handle var was directly accessed in places vs being ensureOpened but I think that is due to checks if the wallet is not open which should be fine as it replaces what I think was current functionality anyways. May be something to look into in the future to see if it could be hanlded a bit differently/safer" |
2 fixes in one, one which fixes syncing and another which fixes a crash bug