Uh oh!
There was an error while loading. Please reload this page.
Conversation
TODO: remove (comment?) dead code litescribe_api.dart, litescribe_response.dart, address_inscription_response.dart are now orphaned
w a single input send-all
it destroys them
had been testing this locally TODO: merge cypherstack/bitcoindart#9 and update it again
danrmiller
commented
Apr 21, 2026
Collaborator
I've been testing this and all good so far. |
`dart format $(git diff --name-only origin/staging...HEAD | grep '\.dart$')`
`dart format $(git diff --name-only origin/staging...HEAD | grep '\.dart$')`
`dart format $(git diff --name-only origin/staging...HEAD | grep '\.dart$')`
Both branches fixed the same followers->following bug in toMap(); conflict was indentation-only.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## staging #1297 +/- ##
============================================
- Coverage 66.22% 4.87% -61.35%
============================================
Files 14 1050 +1036 Lines 900 107031 +106131 ============================================
+ Hits 596 5217 +4621 - Misses 304 101814 +101510 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Replace PowerShell workflow with bash-based test.yaml from tests branch (rustup install, valac/libtss2-dev deps, git_versions stubs, bash secrets, ensure_test_app_config.sh, prebuild.sh, build_runner, coverage checks) - Add scripts/ensure_test_app_config.sh (stub app_config.g.dart for CI) - Add test infrastructure: hive_ce_test_utils, mock_electrum_server, platform_test_overrides - Update test files from tests branch (change_now, node_service, lockscreen, create_pin, firo_wallet, price, electrumx, cached_electrumx, node_card, node_options_sheet, utilities) - Delete stale mock files; regenerate all mocks via build_runner - Add testNodeConnectionProvider + typedef to test_node_connection.dart; switch node_card, node_options_sheet, add_edit_node_view, node_details_view to call via provider so platform_test_overrides can intercept in tests - Fix logger infinite recursion: swallow dispatch errors instead of recursively calling t() which causes StackOverflow in tests - Upgrade bitcoindart to b02aaf6c (adds isParticl param used by particl_wallet) with dependency_overrides entry to beat bip47's pin - Pin dart_style 3.1.3 and analyzer <8.4.0 in pubspec.lock for build_runner
- dart format node_card, node_options_sheet, add_edit_node_view, node_details_view (format check would have failed on CI) - Switch checkout to submodules:recursive parameter (from ci_fixes); drops separate git submodule update step
sneurlax
commented
Apr 29, 2026
MemberAuthor
This does currently include #1301 even tho it is a draft itself and I would recommend against including it without more work |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes
transfer(not justtransferChecked) #1286 fix/solana-tokensTodo: