Uh oh!
There was an error while loading. Please reload this page.
Fix throw when toggling Tor with unopened cryptonote family wallets - #1275
Fix throw when toggling Tor with unopened cryptonote family wallets#1275sneurlax wants to merge 6 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## staging #1275 +/- ##
===========================================
+ Coverage 4.82% 4.93% +0.10%
===========================================
Files 1064 1064 Lines 107929 108022 +93 ===========================================
+ Hits 5212 5330 +118 + Misses 102717 102692 -25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
db30ba4 to
4e93483Comparesneurlax
commented
May 15, 2026
Comments: For example in https://www.github.com/cypherstack/stack_wallet/blob/211971b5d7c6cac19173071026388dbaf756e8ab/lib/pages/settings_views/global_settings_view/manage_nodes_views/add_edit_node_view.dart#L306-L339 |
When you toggle Tor with an uninitialized cryptonote wallet, it throws. This isn't fatal. The fix uses the same guard pattern other functions use.
This fix is admittedly optional: it's not a critical fix but rather a cosmetic/log-cleaning fix.