Skip to content

Fix default Solana token list and support transfer (not just transferChecked) - #1286

Merged
rehrar merged 2 commits into
stagingfrom
fix/solana-tokens
Apr 29, 2026
Merged

Fix default Solana token list and support transfer (not just transferChecked)#1286
rehrar merged 2 commits into
stagingfrom
fix/solana-tokens

Conversation

@sneurlax

Copy link
Copy Markdown
Member

No description provided.

danrmiller
danrmiller previously approved these changes Apr 26, 2026

@danrmillerdanrmiller left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the token transaction parsing is missing the "innerInstructions" and those get missed.

I'm also not sure about the splTransfers.length != 1, I'm pretty sure that is going to miss things on multi-recipient transactions.

But those can be addresses seperately.

@codecov-commenter

codecov-commenter commented Apr 26, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.89%. Comparing base (b905ad3) to head (a8726af).
⚠️ Report is 3 commits behind head on staging.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## staging #1286 +/- ##
========================================
Coverage 74.89% 74.89% ========================================
Files 11 11 Lines 685 685 ========================================
Hits 513 513 Misses 172 172 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rehrar
rehrar merged commit b5cd26d into stagingApr 29, 2026
0 of 2 checks passed
@danrmiller
danrmiller deleted the fix/solana-tokens branch April 29, 2026 04:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sneurlax@codecov-commenter@danrmiller@rehrar