Skip to content

Fix PayNyms: use PayNym.rs - #1294

Merged
julian-CStack merged 21 commits into
stagingfrom
fix/paynym
May 13, 2026
Merged

Fix PayNyms: use PayNym.rs#1294
julian-CStack merged 21 commits into
stagingfrom
fix/paynym

Conversation

@sneurlax

@sneurlaxsneurlax commented Apr 6, 2026

Copy link
Copy Markdown
Member
  • Merge P2TR support bip47#9
  • Update stack_wallet#fix/paynym to point back to the new bip47#main by commit hash

or we could separate P2TR support out and just fix existing functionality by resetting fix/paynym to e2754ad

@sneurlax
sneurlax marked this pull request as ready for review May 13, 2026 02:06
julian-CStack
julian-CStack previously approved these changes May 13, 2026

@julian-CStackjulian-CStack left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I haven't run/tested personally yet

@codecov

codecovBot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 5.78778% with 293 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.93%. Comparing base (db0c225) to head (cf7251b).
⚠️ Report is 1 commits behind head on staging.

Files with missing linesPatch %Lines
...llet/wallet_mixin_interfaces/paynym_interface.dart0.00%186 Missing ⚠️
lib/pages/paynym/paynym_claim_view.dart0.00%57 Missing ⚠️
...ts/custom_buttons/paynym_follow_toggle_button.dart0.00%42 Missing ⚠️
lib/models/paynym/paynym_account_lite.dart64.28%5 Missing ⚠️
lib/utilities/paynym_is_api.dart77.77%2 Missing ⚠️
lib/models/paynym/paynym_claim.dart66.66%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## staging #1294 +/- ##
===========================================
+ Coverage 4.82% 4.93% +0.10% 
===========================================
Files 1064 1064 Lines 107921 107980 +59 ===========================================
+ Hits 5208 5328 +120 + Misses 102713 102652 -61 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julian-CStack
julian-CStack merged commit 665e21c into stagingMay 13, 2026
3 checks passed
@sneurlax
sneurlax deleted the fix/paynym branch May 27, 2026 16:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sneurlax@julian-CStack