Skip to content

Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048

Merged
codablock merged 5 commits into
dashpay:developfrom
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged

Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom
codablock:pr_islock_sigs_cleanup

Conversation

@codablock

@codablockcodablock commented Aug 7, 2019

Copy link
Copy Markdown

This should reduce the required size of the llmq directory a lot.

We should also backport this to 0.14.0.3.

@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock added this to the 14.1 milestone Aug 7, 2019
PastaPastaPasta
PastaPastaPasta reviewed Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock

codablock commented Aug 8, 2019

Copy link
Copy Markdown
Author

Test failure is due to #3051

UdjinM6
UdjinM6 previously approved these changes Aug 8, 2019
View reviewed changes

@UdjinM6UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

PastaPastaPasta
PastaPastaPasta approved these changes Aug 8, 2019
View reviewed changes

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

UdjinM6
UdjinM6 approved these changes Aug 8, 2019
View reviewed changes

@UdjinM6UdjinM6 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

@codablock
codablock merged commit 13e0235 into dashpay:developAug 12, 2019
@codablock
codablock deleted the pr_islock_sigs_cleanup branch August 12, 2019 07:35
codablock added a commit to codablock/dash that referenced this pull request Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock mentioned this pull request Aug 12, 2019
Merged
MIPPL pushed a commit to biblepay/biblepay that referenced this pull request Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit to panleone/PIVX that referenced this pull request Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit to PIVX-Project/PIVX that referenced this pull request Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed by codablock · Pull Request #3048 · dashpay/dash · GitHub
Skip to content
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed - #3048
Merged
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Aug 12, 2019
Merged
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed#3048
codablock merged 5 commits into
dashpay:developfrom 
codablock:pr_islock_sigs_cleanup
Conversation
@codablock
@codablockcodablock
commented
Aug 7, 2019

Copy link


Copy Markdown

This should reduce the required size of the llmq directory a lot.
We should also backport this to 0.14.0.3.
@codablock
Remove unused overload of RemoveInstantSendLock
a729fbd
@codablock
Move deletion of recovered sigs into own method
e1a74ca
@codablock
Remove recovered sigs for fully confirmed IS locks
c734ebe
@codablock
Also remove rs_t entries when removing recovered sigs from the outside
fb4bf04
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
@codablockcodablock
added this to the 14.1 milestone
Aug 7, 2019
PastaPastaPasta
PastaPastaPasta
reviewed
Aug 8, 2019
View reviewed changes
Comment threadsrc/llmq/quorums_signing.cpp
@codablock
codablock
commented
Aug 8, 2019

Copy link


Copy Markdown

Author
Test failure is due to #3051
UdjinM6
UdjinM6
previously approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Aug 8, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
UdjinM6
UdjinM6
approved these changes
Aug 8, 2019
View reviewed changes
@UdjinM6UdjinM6
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
@codablock
codablock
merged commit 13e0235
into
dashpay:developAug 12, 2019
@codablock
codablock
deleted the

pr_islock_sigs_cleanup

branch
August 12, 2019 07:35
codablock added a commit
to codablock/dash
that referenced
this pull request
Aug 12, 2019
@codablock
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
8c49d9b
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
@codablockcodablock
mentioned this pull request
Aug 12, 2019
 Merged

MIPPL pushed a commit
to biblepay/biblepay
that referenced
this pull request
Nov 20, 2019
MIPPL
Merge upstream Dash 0.14.0.3 into Biblepay develop
8ab255f
* commit '7d8eab2641023c78a72ccd6efc99fc35fd030a46': (32 commits)
Add 0.14.0.3 change log to release-notes.md (dashpay#3055)
Update release-notes.md for 0.14.0.3 (dashpay#3054)
Bump version to 0.14.0.3 and copy release notes (dashpay#3053)
Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052)
Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048)
Add "instantsendlocks" to getmempoolinfo RPC (dashpay#3047)
Use fEnablePrivateSend instead of fPrivateSendRunning
Show number of InstantSend locks in Debug Console (dashpay#2919)
Optimize on-disk deterministic masternode storage to reduce size of evodb (dashpay#3017)
Add "isValidMember" and "memberIndex" to "quorum memberof" and allow to specify quorum scan count (dashpay#3009)
Implement "quorum memberof" (dashpay#3004)
Bail out properly on Evo DB consistency check failures in ConnectBlock/DisconnectBlock (dashpay#3044)
Do not count 0-fee txes for fee estimation (dashpay#3037)
Fix broken link in PrivateSend info dialog (dashpay#3031)
Merge pull request dashpay#3028 from PastaPastaPasta/backport-12588
Add Dash Core Group codesign certificate (dashpay#3027)
Fix osslsigncode compile issue in gitian-build (dashpay#3026)
Backport bitcoin#12783: macOS: disable AppNap during sync (and mixing) (dashpay#3024)
Remove support for InstantSend locked gobject collaterals (dashpay#3019)
[v0.14.0.x] Update release notes for 0.14.0.2 (dashpay#3012)
...
# Conflicts:
#	.gitignore
#	.travis.yml
#	configure.ac
#	doc/man/biblepay-cli.1
#	doc/man/biblepay-qt.1
#	doc/man/biblepay-tx.1
#	doc/man/biblepayd.1
#	doc/release-notes.md
#	src/clientversion.h
#	src/qt/utilitydialog.cpp
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@codablock@panleone
Remove recovered sigs from the LLMQ db when corresponding IS locks ge…
be20a71
…t confirmed (dashpay#3048)
* Remove unused overload of RemoveInstantSendLock
* Move deletion of recovered sigs into own method
* Remove recovered sigs for fully confirmed IS locks
* Also remove rs_t entries when removing recovered sigs from the outside
CleanupOldRecoveredSigs already does this as the last step, but when
RemoveRecoveredSig is called from the outside (e.g. from InstantSend),
these keys are not removed. This PR fixes this by storing the write time
into rs_r and later uses it to remove the rs_t entry.
Old entries will be incompatible with this (1 byte written in the past,
4 bytes written now). This checked by comparing the data size with
sizeof(uint32_t).
* Add TODO
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UdjinM6UdjinM6UdjinM6 approved these changes
@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

3 participants

@codablock@UdjinM6@PastaPastaPasta