Skip to content

Refactor llmq type consensus param names - #3093

Merged
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged

Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom
UdjinM6:refactorllmqparam

Conversation

@UdjinM6

@UdjinM6UdjinM6 commented Sep 16, 2019

Copy link
Copy Markdown

As suggested in #3087 (comment)

@UdjinM6UdjinM6 added this to the 14.1 milestone Sep 16, 2019
PastaPastaPasta
PastaPastaPasta requested changes Sep 16, 2019
View reviewed changes

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.

PastaPastaPasta
PastaPastaPasta requested changes Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h Outdated
PastaPastaPasta
PastaPastaPasta previously approved these changes Sep 16, 2019
View reviewed changes

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes

nmarley
nmarley previously approved these changes Sep 17, 2019
View reviewed changes

@nmarleynmarley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK

@PastaPastaPasta What is the scripted-diff stuff?

@PastaPastaPasta

PastaPastaPasta commented Sep 17, 2019•
edited
Loading

Copy link
Copy Markdown
Member

@PastaPastaPasta What is the scripted-diff stuff

Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs

codablock
codablock previously approved these changes Sep 22, 2019
View reviewed changes

@codablockcodablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6

UdjinM6 commented Sep 22, 2019

Copy link
Copy Markdown
Author

Rebased

codablock
codablock previously approved these changes Sep 22, 2019
View reviewed changes

@codablockcodablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

PastaPastaPasta
PastaPastaPasta previously approved these changes Sep 23, 2019
View reviewed changes

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)

@UdjinM6

UdjinM6 commented Sep 23, 2019

Copy link
Copy Markdown
Author

llmq-is-cl-conflicts.py failed, should be fixed by #3094

@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6

UdjinM6 commented Sep 23, 2019

Copy link
Copy Markdown
Author

Rebased to make sure Travis is happy now.

codablock
codablock approved these changes Sep 23, 2019
View reviewed changes

@codablockcodablock left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

nmarley
nmarley approved these changes Sep 23, 2019
View reviewed changes

@nmarleynmarley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK

PastaPastaPasta
PastaPastaPasta approved these changes Sep 23, 2019
View reviewed changes

@PastaPastaPastaPastaPastaPasta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK

@UdjinM6
UdjinM6 merged commit 9f1ee8c into dashpay:developSep 24, 2019
@UdjinM6
UdjinM6 deleted the refactorllmqparam branch November 26, 2020 11:38
panleone pushed a commit to panleone/PIVX that referenced this pull request Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit to PIVX-Project/PIVX that referenced this pull request Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes
+2 more reviewers
@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Refactor llmq type consensus param names by UdjinM6 · Pull Request #3093 · dashpay/dash · GitHub
Skip to content
Refactor llmq type consensus param names - #3093
Merged
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Sep 24, 2019
Merged
Refactor llmq type consensus param names#3093
UdjinM6 merged 1 commit into
dashpay:developfrom 
UdjinM6:refactorllmqparam
Conversation
@UdjinM6
@UdjinM6UdjinM6
commented
Sep 16, 2019

Copy link


Copy Markdown

As suggested in #3087 (comment)
@UdjinM6UdjinM6
added this to the 14.1 milestone
Sep 16, 2019
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small so it's mostly fine, but should be a scripted diff.
PastaPastaPasta
PastaPastaPasta
requested changes
Sep 16, 2019
View reviewed changes
Comment threadsrc/consensus/params.h
Outdated

PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 16, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, scripted diff passes
nmarley
nmarley
previously approved these changes
Sep 17, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, utACK
@PastaPastaPasta What is the scripted-diff stuff?
@PastaPastaPasta
PastaPastaPasta
commented
Sep 17, 2019•

edited

Loading

Copy link


Copy Markdown

Member
@PastaPastaPasta What is the scripted-diff stuff
Basically you can make a change / refactor using a script, put that script into the commit and it gets validated (I think) by travis and code reviewers that way you don't have to look at every single line of the diff if the script is correct https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#scripted-diffs
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK
@UdjinM6
UdjinM6
commented
Sep 22, 2019

Copy link


Copy Markdown

Author
Rebased
codablock
codablock
previously approved these changes
Sep 22, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
previously approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK, scripted diff still passes :)
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
llmq-is-cl-conflicts.py failed, should be fixed by #3094
@UdjinM6
scripted-diff: Refactor llmq type consensus param names
e574bc6
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
@UdjinM6
UdjinM6
commented
Sep 23, 2019

Copy link


Copy Markdown

Author
Rebased to make sure Travis is happy now.
codablock
codablock
approved these changes
Sep 23, 2019
View reviewed changes
@codablockcodablock
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
nmarley
nmarley
approved these changes
Sep 23, 2019
View reviewed changes
@nmarleynmarley
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK
PastaPastaPasta
PastaPastaPasta
approved these changes
Sep 23, 2019
View reviewed changes
@PastaPastaPastaPastaPastaPasta
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-re-utACK
@UdjinM6
UdjinM6
merged commit 9f1ee8c
into
dashpay:developSep 24, 2019
@UdjinM6
UdjinM6
deleted the

refactorllmqparam

branch
November 26, 2020 11:38
panleone pushed a commit
to panleone/PIVX
that referenced
this pull request
Nov 14, 2024
@UdjinM6@panleone
scripted-diff: Refactor llmq type consensus param names (dashpay#3093)
c7e2beb
-BEGIN VERIFY SCRIPT-
sed -i 's/llmqChainLocks/llmqTypeChainLocks/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
sed -i 's/llmqForInstantSend/llmqTypeInstantSend/g' src/*.cpp src/*.h src/*/*.cpp src/*/*.h
-END VERIFY SCRIPT-
Fuzzbawls added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Nov 15, 2024
@Fuzzbawls
Merge#2949: Dash LLMQ backports part 4
c6818fd
c7e2beb scripted-diff: Refactor llmq type consensus param names (dashpay#3093) (UdjinM6)
af7bb99 Re-verify invalid IS sigs when the active quorum set rotated (dashpay#3052) (Alexander Block)
be20a71 Remove recovered sigs from the LLMQ db when corresponding IS locks get confirmed (dashpay#3048) (Alexander Block)
802a933 Don't wake up select if it was already woken up (dashpay#2863) (Alexander Block)
436300d Disable optimistic send in PushMessage by default (dashpay#2859) (Alexander Block)
44ad484 Optimize LLMQs sending of sig shares (dashpay#2704) (Alexander Block)
e01ad46 Fix db leaks in LLMQ db (dashpay#2914) (Alexander Block)
d2a2d15 Print inputs on which we voted and quorums used for signing (dashpay#2907) (Alexander Block)
dce46ad Bail out in few more places when blockchain is not synced yet (dashpay#2888) (UdjinM6)
965a4a7 Use lazy BLS signatures more often and don't always verify self-recovered sigs (dashpay#2860) (Alexander Block)
f4a5a04 cherry pick dashpay#2889 (UdjinM6)
Pull request description:
each commit backports a different PR
ACKs for top commit: c7e2beb
Duddino:
utACK c7e2beb
Liquid369:
utACK c7e2beb
Tree-SHA512: 86425039d01990ff04eea95f5ea4bee4821eaa80c33bab147d5b9407589c799c8293c2da5d5faf10e7e66b65d568444318c87fc274f39b42d2b69b80abafb417
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@PastaPastaPastaPastaPastaPastaPastaPastaPasta approved these changes

+2 more reviewers

@nmarleynmarleynmarley approved these changes
@codablockcodablockcodablock approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

15

Development

Successfully merging this pull request may close these issues.

4 participants

@UdjinM6@PastaPastaPasta@nmarley@codablock