Skip to content

chore(test-suite): move wallet storage persistence in the outer folder - #416

Merged
pshenmic merged 22 commits into
masterfrom
fix/move-test-storage-file
Jun 28, 2022
Merged

chore(test-suite): move wallet storage persistence in the outer folder#416
pshenmic merged 22 commits into
masterfrom
fix/move-test-storage-file

Conversation

@pshenmic

@pshenmicpshenmic commented May 31, 2022

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Each run of test suite creates temporary files in test suite package directory, and they are messing with the current git changes. In this PR, I have added a env variable for setting custom directory for storing these files. Also, configured platform test suite to store this files in platform_root_dir/db directory.

What was done?

  • Added FAUCET_WALLET_STORAGE_DIR env variable (or fall back to current working directory)
  • Added faucet-wallet-use-storage and faucet-wallet-storage-dir in test.sh
  • Updated test suite documentation
  • Added new db directory in the root folder for holding temporary platform test suite files

How Has This Been Tested?

Locally + CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Comment thread.gitignore Outdated
Comment threadpackages/platform-test-suite/lib/test/createFaucetClient.js Outdated
Comment threadpackages/platform-test-suite/lib/test/createFaucetClient.js Outdated
Comment threadpackages/platform-test-suite/bin/test.sh Outdated
@shumkovshumkov changed the title chore: move platform test suite storage persistence in the outer folderchore(test-suite): move wallet storage persistence in the outer folderJun 8, 2022
Comment threadpackages/platform-test-suite/README.md
@pshenmic
pshenmic marked this pull request as draft June 9, 2022 19:11
shumkov
shumkov previously approved these changes Jun 13, 2022

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pshenmic
pshenmic marked this pull request as ready for review June 14, 2022 11:38
Comment threadpackages/platform-test-suite/bin/test.sh Outdated
shumkov
shumkov previously approved these changes Jun 21, 2022

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thephezthephez added this to the v0.22.x milestone Jun 22, 2022

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pshenmic
pshenmic merged commit 4f5b29a into masterJun 28, 2022
@pshenmic
pshenmic deleted the fix/move-test-storage-file branch June 28, 2022 14:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pshenmic@shumkov@thephez