Skip to content

fix: test suite image and environment problems in ci - #505

Merged
strophy merged 10 commits into
v0.23-devfrom
fix-test-suite
Sep 5, 2022
Merged

fix: test suite image and environment problems in ci#505
strophy merged 10 commits into
v0.23-devfrom
fix-test-suite

Conversation

@strophy

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Test suite was failing in CI with DAPI_SEED=yarn NETWORK=testnet and a hang. This is due to a bug (?) introduced in #416 where test.sh is used as an entrypoint without reading environment vars passed in a .env file.

When this is fixed, the tests still fail with:

error: Error injecting plugin No available addresses NoAvailableAddressesError: No available addresses
at GrpcTransport.request (/platform/packages/js-dapi-client/lib/transport/GrpcTransport/GrpcTransport.js:49:13)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async CoreMethodsFacade.getStatus (/platform/packages/js-dapi-client/lib/methods/core/getStatusFactory.js:24:22)
at async ChainPlugin.execStatusFetch (/platform/packages/wallet-lib/src/plugins/Plugins/ChainPlugin.js:75:17)
at async ChainPlugin.onStart (/platform/packages/wallet-lib/src/plugins/Plugins/ChainPlugin.js:98:5)
at async ChainPlugin.startPlugin (/platform/packages/wallet-lib/src/plugins/StandardPlugin.js:35:9)
at async /platform/packages/wallet-lib/src/types/Account/methods/injectPlugin.js:120:11

Removing the ENTRYPOINT from the Dockerfile resolves the problem, why is this entrypoint necessary?

What was done?

  • source .env file if it exists
  • remove --inspect-brk debug mode from mocha
  • remove ENTRYPOINT from Dockerfile

How Has This Been Tested?

Local builds

Breaking Changes

??

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophystrophy added this to the v0.23.0 milestone Aug 24, 2022
@strophy
strophy requested a review from pshenmicAugust 24, 2022 08:34
Comment threadpackages/platform-test-suite/Dockerfile
Comment threadpackages/platform-test-suite/bin/test.sh
pshenmic
pshenmic previously approved these changes Sep 5, 2022

@pshenmicpshenmic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙🤙

@strophy
strophy requested a review from shumkovSeptember 5, 2022 08:05
@strophy
strophy merged commit 20a7afe into v0.23-devSep 5, 2022
@strophy
strophy deleted the fix-test-suite branch September 5, 2022 10:05
@strophystrophy mentioned this pull request Sep 7, 2022
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@strophy@shumkov@pshenmic