Uh oh!
There was an error while loading. Please reload this page.
feat(dapi): wasm-dpp integration - #801
Closed
markin-io wants to merge 26 commits into
Closed
Conversation
shumkov
requested changes
Feb 23, 2023
| alpine-sdk \ | ||
| zeromq-dev | ||
| zeromq-dev \ | ||
| bash |
markin-ioforce-pushed
the
feat/dapi/wasm-dpp-integration
branch
2 times, most recently
from
March 15, 2023 18:56
8638bba to
cea713cCompare…loading on multiple invocations)
…xture.js` and `getDocumentsFixture.js`
…nstantAssetLockProofFixture.js`
…tionResultHandlerFactory.spec.js`
markin-ioforce-pushed
the
feat/dapi/wasm-dpp-integration
branch
from
March 22, 2023 11:39
0f4ebee to
14334a9Compareshumkov added a commit
that referenced
this pull request
Aug 19, 2026
The counted-skip feature merged to grovedb develop as 879cdbc2 (dashpay/grovedb#792) and its branch was deleted, so the previous pin (63df14c2) survived only on dangling-commit retention — and was two revisions behind the branch's final reviewed state besides. All 14 workspace entries now pin the merge commit itself. Crossing grovedb #795-#813 costs three mechanical adaptations, none of which touch the ranked read paths' behavior: - The verify_indexed_* family gained a &GroveVersion parameter (grovedb #801). verify_ranked_top_k_proof_v0 and verify_having_range_proof_v0 now take platform_version — their doc claim that nothing in the body needs a version is no longer true — and pass platform_version.drive.grove_version through. - grovedb's Query gained an optional read_mode field; the three literal initializers in the shielded-notes verifiers set it to None. Query's Display prints the field only when Some, so the pinned to_string assertion is unaffected. The unproved counted read (indexed_*_top_k_paginated -> IndexedTopKPage { entries, skipped }) is byte-identical between the old pin and the merge commit; the executors compile unchanged. Ranked (71), shielded (149 drive + 153 drive-abci), and having (38) suites pass.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only