Uh oh!
There was an error while loading. Please reload this page.
feat: make verification functions public - #813
Closed
iammadab wants to merge 2 commits into
Closed
Conversation
QuantumExplorer
commented
Mar 22, 2023
Member
Closing, as this was already done in another PR |
shumkov added a commit
that referenced
this pull request
Jun 18, 2026
…path fix The friendship-path `account' = 0'` item is no longer just "blocked cross-repo" — the upstream key-wallet fix is submitted as rust-dashcore#813 (honor the AccountType `index` instead of a hardcoded 0', red→green test, backward-compatible for account 0). Also correct the framing: it's not a counterparty-interop break (the recipient pays from the shared xpub and ignores accountReference per DIP-15) — it's a single-account limitation, the same gap as the deferred multi-account item, gated on #813. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
shumkov added a commit
that referenced
this pull request
Jun 18, 2026
…path fix The friendship-path `account' = 0'` item is no longer just "blocked cross-repo" — the upstream key-wallet fix is submitted as rust-dashcore#813 (honor the AccountType `index` instead of a hardcoded 0', red→green test, backward-compatible for account 0). Also correct the framing: it's not a counterparty-interop break (the recipient pays from the shared xpub and ignores accountReference per DIP-15) — it's a single-account limitation, the same gap as the deferred multi-account item, gated on #813. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shumkov added a commit
that referenced
this pull request
Jun 19, 2026
…ork() removal Updates all 8 rust-dashcore workspace deps 981e97f1 -> ceee4a9b40 (dev HEAD), which picks up #813 (DashPay account-index derivation path) and #814 (revert of the temporary #808 Core 23 nested-masternode-address SML changes), so platform keeps the existing flat-field masternode shape and no consensus change is needed. The bump also crosses #802 (removed Address::network(), replaced Network with AddressPrefix because an address's prefix is ambiguous across testnet/devnet and legacy-regtest). Migrate the four call sites: - wasm-sdk validate_address: addr.is_valid_for_network(net) — a bool, exactly what it computed and now correct for the shared testnet/devnet prefix. - platform-wallet derivation_path_for_derived_address: the path only distinguishes mainnet (coin 5') from everything else (1'), so probe is_valid_for_network(Mainnet). - platform-wallet-ffi address rendering (2 sites): an address_display_network helper probes mainnet/testnet/regtest, decisive for the bech32m platform-payment addresses rendered here (mainnet ds / testnet+devnet tb / regtest dsrt). Migration tracked in #3939. Full workspace --all-targets compiles. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
57 tasks
shumkov added a commit
that referenced
this pull request
Aug 19, 2026
The counted-skip feature merged to grovedb develop as 879cdbc2 (dashpay/grovedb#792) and its branch was deleted, so the previous pin (63df14c2) survived only on dangling-commit retention — and was two revisions behind the branch's final reviewed state besides. All 14 workspace entries now pin the merge commit itself. Crossing grovedb #795-#813 costs three mechanical adaptations, none of which touch the ranked read paths' behavior: - The verify_indexed_* family gained a &GroveVersion parameter (grovedb #801). verify_ranked_top_k_proof_v0 and verify_having_range_proof_v0 now take platform_version — their doc claim that nothing in the body needs a version is no longer true — and pass platform_version.drive.grove_version through. - grovedb's Query gained an optional read_mode field; the three literal initializers in the shielded-notes verifiers set it to None. Query's Display prints the field only when Some, so the pinned to_string assertion is unaffected. The unproved counted read (indexed_*_top_k_paginated -> IndexedTopKPage { entries, skipped }) is byte-identical between the old pin and the merge commit; the executors compile unchanged. Ranked (71), shielded (149 drive + 153 drive-abci), and having (38) suites pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Need to access the proof verification functions from outside the crate.
What was done?
Make the verify module pub
How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only