Skip to content

feat(wasm-dpp): remove unused documents factory tests - #828

Merged
antouhou merged 9 commits into
v0.24-devfrom
remove_unused_documents_factory_tests
Mar 20, 2023
Merged

feat(wasm-dpp): remove unused documents factory tests#828
antouhou merged 9 commits into
v0.24-devfrom
remove_unused_documents_factory_tests

Conversation

@antouhou

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

A lot of WASM tests for the DocumentFactory were just duplicates of the JS tests

What was done?

Removed tests that didn't test anything

How Has This Been Tested?

Run tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@antouhouantouhou added this to the v0.24.0 milestone Mar 17, 2023
@antouhou
antouhou requested a review from shumkov as a code ownerMarch 17, 2023 08:44
@antouhou
antouhou merged commit 0710b99 into v0.24-devMar 20, 2023
@antouhou
antouhou deleted the remove_unused_documents_factory_tests branch March 20, 2023 10:37
QuantumExplorer added a commit that referenced this pull request Aug 24, 2026
…st model
753a11f1 brings grovedb #828 (O(height) dense-buffer root maintenance),
#829 (fixed per-append cost: churn buffer, fixed dense model, amortized
compaction, constant-price frontier) and #830 (prepaid puts carry no
seek). Under GROVE_V4 a CommitmentTreeInsert now meters the same figure
at every position of the tree — compaction included — and the estimators
price that model tightly instead of bounding it. GROVE_V3 (protocol 13)
figures are locked and unchanged.
API fallout: CommitmentTree::open and compute_current_state_root take
the grove version (the load charge and root read are now versioned) —
threaded through the shielded snapshot bake/apply paths and the genesis
seeder test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@antouhou@markin-io