Skip to content

chore(sdk): add eslint - #829

Merged
markin-io merged 8 commits into
masterfrom
chore/sdk/add-eslint-master
Mar 17, 2023
Merged

chore(sdk): add eslint#829
markin-io merged 8 commits into
masterfrom
chore/sdk/add-eslint-master

Conversation

@markin-io

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Adds eslint

What was done?

  • Added eslint package for typescript with airbnb config, handled JS files as well
  • Changed certain from errors into warnings in order to not drown in long refactoring which could possibly break some code (check warnRules in .eslintrc.js)
  • Manually fixed eslint errors that do not alter logical constructions (missing vars, long lines, rearranging imports and etc)
  • eslint-ignored errors that require changes in logical constructions and could possibly cause bugs

How Has This Been Tested?

  • CI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-iomarkin-io added this to the v0.23.x milestone Mar 17, 2023
@markin-io
markin-io merged commit 70a44a6 into masterMar 17, 2023
@markin-io
markin-io deleted the chore/sdk/add-eslint-master branch March 17, 2023 12:06
QuantumExplorer pushed a commit that referenced this pull request Apr 20, 2023
markin-io added a commit that referenced this pull request Apr 21, 2023
markin-io added a commit that referenced this pull request Apr 21, 2023
QuantumExplorer added a commit that referenced this pull request Aug 24, 2026
…st model
753a11f1 brings grovedb #828 (O(height) dense-buffer root maintenance),
#829 (fixed per-append cost: churn buffer, fixed dense model, amortized
compaction, constant-price frontier) and #830 (prepaid puts carry no
seek). Under GROVE_V4 a CommitmentTreeInsert now meters the same figure
at every position of the tree — compaction included — and the estimators
price that model tightly instead of bounding it. GROVE_V3 (protocol 13)
figures are locked and unchanged.
API fallout: CommitmentTree::open and compute_current_state_root take
the grove version (the load charge and root read are now versioned) —
threaded through the shielded snapshot bake/apply paths and the genesis
seeder test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@markin-io@antouhou