Skip to content

fix(rs-drive-abci): config file is broken - #892

Merged
lklimek merged 4 commits into
feat/abci_validationfrom
fix/config-broken
Apr 7, 2023
Merged

fix(rs-drive-abci): config file is broken#892
lklimek merged 4 commits into
feat/abci_validationfrom
fix/config-broken

Conversation

@lklimek

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Envy doesn't handle correctly int values inside flattened structs. See softprops/envy#26

What was done?

  1. Use string values in config structs and implement getters
  2. Fixed small issue with Docker image

How Has This Been Tested?

  • Unit test passes
  • Started drive-abci in Docker

Breaking Changes

none

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek
lklimek requested review from QuantumExplorer and removed request for antouhou and shumkovApril 6, 2023 20:52
@lklimek
lklimek merged commit 0d51294 into feat/abci_validationApr 7, 2023
@lklimek
lklimek deleted the fix/config-broken branch April 7, 2023 06:09
QuantumExplorer added a commit that referenced this pull request Jul 15, 2026
…rows + land the #893 crash-fix pin
Follow-up to #4129 (merged before its review completed) addressing
thepastaclaw's blocking finding, plus the rust-dashcore bump that was
pushed to the #4129 branch after its merge and never landed:
- restore_address_pool: a legacy row persisted before the typed-key
column (empty key -> public_key: None) no longer strips the typed BLS
key the gap-limit prederivation put at the same index — pre-typed-key
stores otherwise lose in-memory operator pubkeys at load and
masternode operator-ownership matching silently breaks. No-op for
post-migration rows (they always carry their key). Test pins both
directions. Legacy Ed25519 platform-node keys are hardened-only and
their old account-level batch was dropped by the schema migration, so
they cannot be recovered at load; per the pre-release convention those
stores re-derive on delete+re-import.
- PersistentCoreAddress.keyType doc: corrected the false "re-tags on
every load" claim — load only reads the snapshot; re-tagging happens
on the next persist pulse.
- Bump rust-dashcore to 19690d31 (merged #893, fixes#892): the
sparse-filter startup crash-loop fix, verified live on the previously
crash-looping simulator state.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lklimek@shumkov