Skip to content

fix(dashmate): api binds to all interfaces - #893

Merged
shumkov merged 28 commits into
v0.24-devfrom
feat/dashmate-json-rpc
Apr 7, 2023
Merged

fix(dashmate): api binds to all interfaces#893
shumkov merged 28 commits into
v0.24-devfrom
feat/dashmate-json-rpc

Conversation

@pshenmic

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Bind dashmate to localhost for security reason.

What was done?

  • bind dashmate rpc api to 127.0.0.1
  • add curl to dashmate docker image (used in smoke tests)

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkovshumkov changed the title feat(dashmate): bind dashmate json rpc to localhostfix(dashmate): dashmate api binds to all interfacesApr 7, 2023
@shumkovshumkov changed the title fix(dashmate): dashmate api binds to all interfacesfix(dashmate): api binds to all interfacesApr 7, 2023

@shumkovshumkov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov
shumkov merged commit c3e5a71 into v0.24-devApr 7, 2023
@shumkov
shumkov deleted the feat/dashmate-json-rpc branch April 7, 2023 17:07
@thephezthephez added this to the v0.24.0 milestone Apr 24, 2023
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
@markin-iomarkin-io mentioned this pull request Apr 26, 2023
5 tasks
markin-io pushed a commit that referenced this pull request Apr 26, 2023
Co-authored-by: Ivan Shumkov <ivan@shumkov.ru>
QuantumExplorer added a commit that referenced this pull request Jul 15, 2026
rust-dashcore#893 merged; the temporary PR-head pin (828f707d) now
points at the canonical merge commit. Same code content for dash-spv's
sparse-filter fix.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer added a commit that referenced this pull request Jul 15, 2026
…rows + land the #893 crash-fix pin
Follow-up to #4129 (merged before its review completed) addressing
thepastaclaw's blocking finding, plus the rust-dashcore bump that was
pushed to the #4129 branch after its merge and never landed:
- restore_address_pool: a legacy row persisted before the typed-key
column (empty key -> public_key: None) no longer strips the typed BLS
key the gap-limit prederivation put at the same index — pre-typed-key
stores otherwise lose in-memory operator pubkeys at load and
masternode operator-ownership matching silently breaks. No-op for
post-migration rows (they always carry their key). Test pins both
directions. Legacy Ed25519 platform-node keys are hardened-only and
their old account-level batch was dropped by the schema migration, so
they cannot be recovered at load; per the pre-release convention those
stores re-derive on delete+re-import.
- PersistentCoreAddress.keyType doc: corrected the false "re-tags on
every load" claim — load only reads the snapshot; re-tagging happens
on the next persist pulse.
- Bump rust-dashcore to 19690d31 (merged #893, fixes#892): the
sparse-filter startup crash-loop fix, verified live on the previously
crash-looping simulator state.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
QuantumExplorer added a commit that referenced this pull request Jul 15, 2026
…rows + land the #893 crash-fix pin (#4132)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pshenmic@shumkov@thephez