Uh oh!
There was an error while loading. Please reload this page.
fix(dashmate): missing fallback fee on testnet with core v20 - #963
Conversation
5fce55b to
db8d94fCompareUh oh!
There was an error while loading. Please reload this page.
| @@ -51,6 +51,7 @@ masternodeblsprivkey={{=it.core.masternode.operator.privateKey}} | |||
| {{?}} | |||
| {{? it.network === 'testnet'}}testnet=1 | |||
There was a problem hiding this comment.
this should also apply to all networks, including local & devnet (not sure about production)
There was a problem hiding this comment.
@PastaPastaPasta@thephez should this value be set on mainnet as well?
There was a problem hiding this comment.
From slack to keep history.
this should also apply to all networks, including local & devnet (not sure about production)
No, these changes (backport of bitcoin/bitcoin#16524) do not affect production (mainnet); it was already 0 in the past for mainnet.
As release note says:
-fallbackfeewas 0 (disabled) by default for the main chain, but 20000 by default for the test chains. Now it is 0 by default for all chains. Testnet and regtest users will have to add fallbackfee=20000 to their configuration if they weren't setting it and they want it to keep working like before.
For dash default value were not 20.000 but 1000. So, you need to specify in config fallbackfee=0.00001 to keep same behavior as before for testnet/regnet/etc.
Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
strophy
commented
Apr 28, 2023
Looks like CI is failing because it depends on older |
Per the decision on the blocker: the pinned branch is re-cut without #866's `rescan_committed_range`. Two reasons, and the second is the one that decides it. The Codex finding stands — the sweep accumulates every match from the birth height into one `BTreeMap` and queues them together, so an eclipsing compact-filter peer can turn a full-history rescan into a chain-length allocation followed by millions of block requests, and nothing upstream bounds it yet. More decisive is the honest case. On a real long-history CoinJoined restore the #846 backward sweep ran 191 times, reached a 2.9 GB footprint, and was killed by jetsam before finishing; the coalescing fix for that is dashpay/rust-dashcore#974, which is not merged. Shipping #866 without #974 would trade a mid-sync stall for a restore that kills the app — and long-history migrated wallets are exactly this release's audience. What the pin still carries is the point of this PR: #964, #960, #955, #947 and #946, the six sync-stall fixes, plus #945, #928, #963, #965, #967, #970 and #980. Dropping #866 restores the status quo of the previous pin rather than introducing a regression — #846's mid-sync invisibility was never fixed in what shipped — and the migrated-wallet heal (#4377) does a full rescan, so it does not lean on this sweep. #866 and #974 come back together next cycle, with a bounded drain for the accumulation finding. Branch: dashpay/rust-dashcore@chore/sync-fixes-without-swept, re-cut at 33030acf (base #945 plus eight cherry-picks, #866 omitted).
Issue being fixed or feature implemented
Dashmate failed to start core v20 with error about missing
fallbackffeeon testnetWhat was done?
Add
fallbackffeeon testnetHow Has This Been Tested?
Untested
Breaking Changes
None, this has always been the fallbackfee on testnet I think
Checklist:
For repository code-owners and collaborators only