Uh oh!
There was an error while loading. Please reload this page.
fix(dashmate): already configured preset is ignored - #974
Merged
Conversation
shuplenkov
previously approved these changes
Apr 25, 2023
Uh oh!
There was an error while loading. Please reload this page.
5 tasks
shuplenkov
approved these changes
Apr 26, 2023
markin-io pushed a commit
that referenced
this pull request
Apr 28, 2023
5 tasks
romchornyi pushed a commit
that referenced
this pull request
Aug 25, 2026
Per the decision on the blocker: the pinned branch is re-cut without #866's `rescan_committed_range`. Two reasons, and the second is the one that decides it. The Codex finding stands — the sweep accumulates every match from the birth height into one `BTreeMap` and queues them together, so an eclipsing compact-filter peer can turn a full-history rescan into a chain-length allocation followed by millions of block requests, and nothing upstream bounds it yet. More decisive is the honest case. On a real long-history CoinJoined restore the #846 backward sweep ran 191 times, reached a 2.9 GB footprint, and was killed by jetsam before finishing; the coalescing fix for that is dashpay/rust-dashcore#974, which is not merged. Shipping #866 without #974 would trade a mid-sync stall for a restore that kills the app — and long-history migrated wallets are exactly this release's audience. What the pin still carries is the point of this PR: #964, #960, #955, #947 and #946, the six sync-stall fixes, plus #945, #928, #963, #965, #967, #970 and #980. Dropping #866 restores the status quo of the previous pin rather than introducing a regression — #846's mid-sync invisibility was never fixed in what shipped — and the migrated-wallet heal (#4377) does a full rescan, so it does not lean on this sweep. #866 and #974 come back together next cycle, with a bounded drain for the accumulation finding. Branch: dashpay/rust-dashcore@chore/sync-fixes-without-swept, re-cut at 33030acf (base #945 plus eight cherry-picks, #866 omitted).
HashEngineering added a commit
to HashEngineering/platform
that referenced
this pull request
Aug 25, 2026
…th dev (a5d7ea0b) The dashpay#979 engine fixes and dashpay#974's coalesced committed-range sweeps now live on one rev: fix/key-wallet-rescan-changeset merged with dev, with the durable pending-sweep re-keyed to the coalesced model (manager-level swept-awaiting-commit receipt, resume-only seeding). Replaces the two superseded pins this branch carried (6768f983, 9a68e652). The rev also carries rust-dashcore dashpay#981 (Mnemonic::from_phrase is now the auto-detecting parse), so the three parse_mnemonic_any_language wordlist walks (wallet_lifecycle, rs-platform-wallet-ffi derivation + identity_keys_from_mnemonic, rs-sdk-ffi signer_simple) collapse to thin delegates and the language-tagged test call sites drop the argument. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
If
dashmate setupcommand is called with the preset argument then there is no check is this preset already configuredWhat was done?
How Has This Been Tested?
Manually
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only