feat(key-wallet): seed sync checkpoint from birth_height

[xdustinface]

WalletManager::import_wallet_from_extended_priv_key, import_wallet_from_xpub, and import_wallet_from_bytes (plus the matching FFI) gain a birth_height parameter so previously-used keys can rescan from a chosen height instead of being silently anchored at the chain tip.

Based on:

• fix: seed sync checkpoints from birth_height in ManagedWalletInfo ctors #692

Summary by CodeRabbit

• New Features

  • Wallet imports now support an explicit starting sync height, helping imported wallets begin from a chosen checkpoint instead of always starting from the beginning.

• Bug Fixes

  • Updated wallet import behavior so imported wallet state is initialized consistently with the provided starting height.
  • Aligned related import flows and tests with the updated wallet import parameters.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b1ec6ce0-5873-4734-ab28-7a865baff9d2

📥 Commits

Reviewing files that changed from the base of the PR and between 647fa98 and 848fdc8.

📒 Files selected for processing (8)

• dash-spv-ffi/tests/test_wallet_manager.rs
• key-wallet-ffi/FFI_API.md
• key-wallet-ffi/src/wallet_manager.rs
• key-wallet-ffi/src/wallet_manager_serialization_tests.rs
• key-wallet-ffi/src/wallet_manager_tests.rs
• key-wallet-ffi/tests/test_import_wallet.rs
• key-wallet-manager/src/lib.rs
• key-wallet-manager/tests/test_serialized_wallets.rs

---

📝 Walkthrough

Walkthrough

Wallet import APIs in key-wallet-manager (import_wallet_from_extended_priv_key, import_wallet_from_xpub, import_wallet_from_bytes) now require an explicit birth_height parameter used to seed ManagedWalletInfo. The corresponding FFI function and documentation are updated to add this parameter, and existing test call sites are updated accordingly.

Changes

Explicit birth_height for wallet import

Layer / File(s)	Summary
WalletManager import functions accept birth_height key-wallet-manager/src/lib.rs	import_wallet_from_extended_priv_key, import_wallet_from_xpub, and import_wallet_from_bytes gain a birth_height: CoreBlockHeight parameter, using it to seed ManagedWalletInfo instead of self.last_processed_height(), with updated doc comments.
FFI signature and docs key-wallet-ffi/src/wallet_manager.rs, key-wallet-ffi/FFI_API.md	wallet_manager_import_wallet_from_bytes adds a birth_height: u32 parameter, forwards it to the underlying manager call, and updates safety docs and the documented C signature.
Test call sites updated dash-spv-ffi/tests/test_wallet_manager.rs, key-wallet-ffi/src/wallet_manager_serialization_tests.rs, key-wallet-ffi/src/wallet_manager_tests.rs, key-wallet-ffi/tests/test_import_wallet.rs, key-wallet-manager/tests/test_serialized_wallets.rs	Existing tests pass an additional 0 (or 50_000) argument to wallet_manager_import_wallet_from_bytes/import_wallet_from_bytes, with a new test scenario asserting seeded birth_height, synced_height, and last_processed_height values after import.

Estimated code review effort: 2 (Simple) | ~12 minutes

Sequence Diagram(s)

sequenceDiagram
participant Test as test_serialized_wallets
participant Manager as WalletManager
participant Info as ManagedWalletInfo
Test->>Manager: import_wallet_from_bytes(bytes, 50_000)
Manager->>Manager: deserialize wallet, compute wallet_id
Manager->>Info: init with birth_height=50_000
Info-->>Manager: synced_height=49_999, last_processed_height=49_999
Manager-->>Test: WalletId

Loading

Possibly related issues

• Let callers specify birth_height on wallet add/import paths #688: Both changes make birth_height an explicit parameter in the wallet_manager_import_wallet_from_bytes import path.

Suggested labels:ready-for-review

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title is concise and accurately summarizes the main change: seeding wallet sync checkpoints from birth_height.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/feed-wallet-synced-height

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.66%. Comparing base (647fa98) to head (848fdc8).

Files with missing lines	Patch %	Lines
key-wallet-manager/src/lib.rs	33.33%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## dev #693 +/- ##
==========================================
+ Coverage 73.34% 73.66% +0.31% 
==========================================
Files 324 324 Lines 72923 72927 +4 ==========================================
+ Hits 53486 53722 +236 + Misses 19437 19205 -232 

Flag	Coverage Δ
core	76.94% <ø> (ø)
ffi	47.89% <100.00%> (+2.39%)	⬆️
rpc	20.00% <ø> (ø)
spv	90.63% <ø> (+0.04%)	⬆️
wallet	72.96% <33.33%> (-0.01%)	⬇️

Files with missing lines	Coverage Δ
key-wallet-ffi/src/wallet_manager.rs	71.84% <100.00%> (-1.86%)	⬇️
key-wallet-manager/src/lib.rs	74.82% <33.33%> (-0.44%)	⬇️

... and 16 files with indirect coverage changes

[github-actions]

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

[github-actions]

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

[ZocoLini]

If we are going this way we also need method to expose the latest known and valid height before starting sync (ergo latest checkpoint)

[xdustinface]

If we are going this way we also need method to expose the latest known and valid height before starting sync (ergo latest checkpoint)

How is it related or neccessary for this PR? This is just a preparation PR. I have a few coming.