test(dash-spv): add multi-wallet integration tests

[xdustinface]

Adds tests_multi_wallet.rs plus extensions to tests_basic.rs and tests_restart.rs covering per-wallet sync behavior:

• Two wallets in one WalletManager sync independently.
• Runtime wallet-add with birth_height before, at, and beyond tip, asserting existing wallets' synced_height and last_processed_height never regress.
• Deep historical rescan triggered by a birth_height = 0 runtime add.
• A block funding two wallets is attributed correctly to each after both are added at runtime.
• Runtime add against a Syncing-state FiltersManager.
• Runtime-add rescan composed with a live tip advance.
• Restart of a fully-synced client emits no rescan, then runtime-adding a second wallet only catches up the new wallet.

Based on:

• fix: seed sync checkpoints from birth_height in ManagedWalletInfo ctors #692
• feat(key-wallet): seed sync checkpoint from birth_height #693
• feat: per-wallet filter scan and runtime wallet catch-up #694

Summary by CodeRabbit

• Tests
  • Expanded test coverage for multi-wallet SPV synchronization scenarios, including wallet isolation and edge case handling during syncing
  • Introduced test infrastructure improvements with helper utilities for wallet setup and synchronization verification
  • Added new test cases covering runtime wallet additions and complex synchronization behavior across multiple wallet configurations

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: caf21a6c-e50d-4f74-8765-91504232f812

📥 Commits

Reviewing files that changed from the base of the PR and between a6d0b45 and 7090009.

📒 Files selected for processing (4)

• dash-spv/tests/dashd_sync/helpers.rs
• dash-spv/tests/dashd_sync/main.rs
• dash-spv/tests/dashd_sync/tests_basic.rs
• dash-spv/tests/dashd_sync/tests_multi_wallet.rs

---

📝 Walkthrough

Walkthrough

This PR introduces comprehensive multi-wallet SPV synchronization test coverage for the Dash SPV library. It adds shared test constants and helper functions, registers a new test module, refactors existing tests to use centralized test data, and implements four end-to-end test scenarios exploring runtime wallet additions, shared blocks, concurrent initialization, and rescan behavior during tip advancement.

Changes

Multi-Wallet SPV Sync Test Coverage

Layer / File(s)	Summary
Test Helpers & Constants dash-spv/tests/dashd_sync/helpers.rs	Added EMPTY_MNEMONIC and SECONDARY_MNEMONIC constants with BIP39 documentation; introduced wait_for_wallet_synced function that monitors per-wallet sync height via WalletEvent stream with 30-second deadline.
Test Runner Wiring dash-spv/tests/dashd_sync/main.rs	Registered new tests_multi_wallet module in test runner.
Test Refactoring dash-spv/tests/dashd_sync/tests_basic.rs	Refactored test_sync_empty_wallet to use centralized EMPTY_MNEMONIC constant; added test_empty_wallet_manager_no_spurious_rescan to verify no spurious sync events for empty manager; removed test_sync_two_wallets_same_client in favor of multi-wallet module tests.
Multi-Wallet Test Scenarios dash-spv/tests/dashd_sync/tests_multi_wallet.rs	Implemented four end-to-end test scenarios: runtime wallet additions with catch-up and rescan, shared funding blocks across wallets with isolation verification, mid-flight additions during initial sync, and rescan with concurrent tip advancement; added helper functions reserve_first_address and wallet_heights for address allocation and per-wallet height snapshots.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

A rabbit's warren needs many halls,

For wallets fast and SPV calls,

Each tunnel syncs without a stall,

One mnemonic, shared by all! 🐰✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test(dash-spv): add multi-wallet integration tests' accurately and concisely summarizes the main objective of the pull request, which is to add comprehensive multi-wallet integration tests to the dash-spv test suite.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/multi-wallet-integration-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.17%. Comparing base (1cb414b) to head (7090009).
⚠️ Report is 2 commits behind head on v0.42-dev.

Additional details and impacted files

@@ Coverage Diff @@## v0.42-dev #697 +/- ##
==========================================
Coverage 71.17% 71.17% ==========================================
Files 320 320 Lines 68602 68602 ==========================================
+ Hits 48827 48830 +3 + Misses 19775 19772 -3 

Flag	Coverage Δ
core	76.19% <ø> (ø)
ffi	45.79% <ø> (ø)
rpc	20.00% <ø> (ø)
spv	87.49% <ø> (+0.01%)	⬆️
wallet	69.77% <ø> (ø)
see 1 file with indirect coverage changes

[github-actions]

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@dash-spv/tests/dashd_sync/tests_multi_wallet.rs`:
- Around line 50-51: Add the #[ignore] attribute to network-dependent
integration tests so they don't run by default: place #[ignore] immediately
above each #[tokio::test] declaration in this file (including the test function
test_sync_two_wallets_same_client and the other four network-dependent test
cases mentioned) so they are excluded from regular runs and can be executed
explicitly with -- --ignored in the dedicated integration job.
In `@dash-spv/tests/dashd_sync/tests_restart.rs`:
- Around line 212-213: Add the #[ignore] attribute to the test function
declaration for test_runtime_add_after_restart so the test is not run by
default; specifically, place #[ignore] above the existing #[tokio::test] on the
test_runtime_add_after_restart function so it will only run when invoked with --
--ignored.
- Around line 247-263: Mark the network-dependent test (tests_restart.rs) with
#[ignore] and change the sync-event draining/watch logic to explicitly handle
broadcast lag: when draining client_handle.sync_event_receiver use try_recv()
but detect and handle RecvError::Lagged (don't silently ignore it), and in the
watch loop match recv() errors so that Err(RecvError::Lagged) is handled
separately (e.g., fail or increment a spurious counter) rather than treating all
recv errors the same as a timeout/break; reference the
SyncEvent::FiltersSyncComplete variant, client_handle.sync_event_receiver,
try_recv, recv, and RecvError::Lagged, and consider starting the receiver
observation before returning from wait_for_sync()/the function that spawns the
upstream rescan to avoid missing early events.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b4412e3d-697d-4715-918c-f636c88383a5

📥 Commits

Reviewing files that changed from the base of the PR and between ca507a9 and 34c27d9.

📒 Files selected for processing (5)

• dash-spv/tests/dashd_sync/helpers.rs
• dash-spv/tests/dashd_sync/main.rs
• dash-spv/tests/dashd_sync/tests_basic.rs
• dash-spv/tests/dashd_sync/tests_multi_wallet.rs
• dash-spv/tests/dashd_sync/tests_restart.rs

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dash-spv/tests/dashd_sync/helpers.rs`:
- Around line 116-118: The match arm that treats Ok(Err(_)) as a hard panic is
incorrect for Tokio broadcast::RecvError::Lagged; update the receiver logic (the
match handling the wallet event channel recv where `target` and
`wallet.synced_height` are used) to detect RecvError::Lagged specifically, and
when lagged: re-read the wallet's current `synced_height` (in case the target
was missed) and continue the polling loop instead of panicking; only panic for
terminal errors (e.g., RecvError::Closed or other non-lagged errors).
- Around line 116-118: The match arm that treats Ok(Err(_)) from
Receiver::recv() as a panic should distinguish RecvError::Lagged from
RecvError::Closed: in the block handling the receiver result (where you
currently have Ok(Err(_)) => panic!(...)), match the error enum explicitly and
on RecvError::Lagged(_) simply continue (or log and continue) because it is
recoverable, while still panicking (or failing the test) only on
RecvError::Closed; reference tokio::sync::broadcast::Receiver::recv(), the
RecvError::Lagged variant, and the existing Ok(Err(_)) panic site in helpers.rs
to locate and update the code.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7558f81c-62da-4a2d-b2a1-19cf8d0d7fbd

📥 Commits

Reviewing files that changed from the base of the PR and between 348c570 and a6d0b45.

📒 Files selected for processing (1)

• dash-spv/tests/dashd_sync/helpers.rs

[QuantumExplorer]

Rubber stamping