Uh oh!
There was an error while loading. Please reload this page.
BUG: dask.array: asarray(..., copy=None) copies in dask==2024.12 - #211
Conversation
ev-br
commented
Dec 5, 2024
Two issues:
|
betatim
commented
Dec 5, 2024
In the standard for If there is nothing we can do to fix this then I think updating the test is fine. |
lucascolley
commented
Dec 5, 2024
Yes, I think it is compatible for Dask to say that they will always copy, and just raise an error for |
ev-br
commented
Dec 5, 2024
The issue with 2024.12 is |
It is compatible for them to always copy with EDIT: the wording in the spec is
and the Dask maintainers appear to be saying 'reusing the existing memory buffer is never possible' (or at least never supported) |
As of dask >= 2024.12, da.from_array() always copies, while before it did not. Thus copy too, to make array_api_compat.dask.array version-independent.
It seems to hang on CI with dask==2024.12
ev-br
commented
Dec 5, 2024
CI is green with three tweaks
|
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: crusaderky <crusaderky@gmail.com>
crusaderky
commented
Dec 12, 2024
@lucascolley@rgommers this PR is blocking everything |
ev-br
commented
Dec 12, 2024
Let's unblock everything then :-) |
closesgh-209