Uh oh!
There was an error while loading. Please reload this page.
BUG: dask: asarray should not materialize the graph - #235
Merged
Conversation
crusaderkyforce-pushed
the
dask_asarray
branch
3 times, most recently
from
January 15, 2025 19:42
c554947 to
a46f8a8Compare
This was referenced Jan 15, 2025
crusaderkyforce-pushed
the
dask_asarray
branch
4 times, most recently
from
January 15, 2025 22:31
2053f7f to
8f8ea9cCompareda.asarray should not materialize the graphda.asarray should not materialize the graphcrusaderkyforce-pushed
the
dask_asarray
branch
2 times, most recently
from
January 16, 2025 14:55
517d0c8 to
ebfefc9Compareda.asarray should not materialize the graphasarray should not materialize the graphcrusaderkyforce-pushed
the
dask_asarray
branch
4 times, most recently
from
January 16, 2025 15:26
7676d2f to
e38c2dbComparecrusaderky
commented
Jan 16, 2025
ContributorAuthor
@ev-br this is ready for review and merge |
ev-br
reviewed
Jan 16, 2025
ev-br
left a comment
Member
There was a problem hiding this comment.
The testing pattern is a bit bizzare, I've to admit. Would be nice if there was a way to make a little more "boring" and explicit.
crusaderky
commented
Jan 16, 2025
ContributorAuthor
I've replaced the fixture with a context manager to make it clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xp.asarrayapplied to a dask array materializes the graph.