Skip to content

Add support for complex number addition - #525

Merged
rgommers merged 2 commits into
mainfrom
cmplx-add
Dec 13, 2022
Merged

Add support for complex number addition#525
rgommers merged 2 commits into
mainfrom
cmplx-add

Conversation

@kgryte

Copy link
Copy Markdown
Contributor

This PR

  • adds support for complex number addition. Complex number addition is well-defined, where (a + bj) + (c + dj) = (a+c) + (c+d)j.
  • Specifies that the special cases described for real-valued floating-point operands apply to the component operations separately. Meaning, operations involving real-valued components (i.e., a, b, c, d) must abide by real-valued floating-point special cases.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 27, 2022
@kgrytekgryte added this to the v2022 milestone Nov 27, 2022

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks @kgryte

@rgommers
rgommers merged commit 8062655 into mainDec 13, 2022
@rgommers
rgommers deleted the cmplx-add branch December 13, 2022 16:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers