Skip to content

Add support for complex number subtraction - #526

Merged
rgommers merged 1 commit into
mainfrom
cmplx-subtract
Dec 13, 2022
Merged

Add support for complex number subtraction#526
rgommers merged 1 commit into
mainfrom
cmplx-subtract

Conversation

@kgryte

@kgrytekgryte commented Nov 27, 2022

Copy link
Copy Markdown
Contributor

This PR

  • adds support for complex number subtraction. Complex number subtraction is well-defined, where (a + bj) - (c + dj) = (a+bj) + (-(c+dj)) = (a+bj)+(-c-dj) = (a-c) + (c-d)j.
  • Specifies that special cases are defined according to complex number addition.
  • updates the input and output array data types to be any numeric data type, not just real-valued data types.
  • this PR depends on gh-525.

@kgrytekgryte added API change Changes to existing functions or objects in the API. topic: Complex Data Types Complex number data types. labels Nov 27, 2022
@kgrytekgryte added this to the v2022 milestone Nov 27, 2022
@kgrytekgryte mentioned this pull request Nov 27, 2022
Closed
rgommers
rgommers approved these changes Dec 13, 2022
View reviewed changes

@rgommersrgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, LGTM

@rgommers
rgommers merged commit 58580d5 into mainDec 13, 2022
@rgommers
rgommers deleted the cmplx-subtract branch December 13, 2022 16:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommersrgommersrgommers approved these changes

Assignees

No one assigned

Labels

API changeChanges to existing functions or objects in the API.topic: Complex Data TypesComplex number data types.

Projects

None yet

Milestone

v2022

Development

Successfully merging this pull request may close these issues.

2 participants

@kgryte@rgommers