Skip to content

Return application_id for service principal lookups - #1245

Merged
andrewnester merged 2 commits into
mainfrom
fix-sp-lookup
Mar 4, 2024
Merged

Return application_id for service principal lookups#1245
andrewnester merged 2 commits into
mainfrom
fix-sp-lookup

Conversation

@andrewnester

@andrewnesterandrewnester commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Changes

Return ApplicationId for service principals lookups

Fixes#1234

Tests

Added (regression) tests

@andrewnesterandrewnester changed the title Added support for custom lookup field and return ApplicationId for service principalsReturn ApplicationId for service principals lookupsMar 4, 2024
@pieternpietern changed the title Return ApplicationId for service principals lookupsReturn application_id for service principal lookupsMar 4, 2024
@codecov-commenter

codecov-commenter commented Mar 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.54%. Comparing base (0839e6f) to head (e4a5196).
Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1245 +/- ##
==========================================
+ Coverage 52.52% 52.54% +0.02% 
==========================================
Files 308 308 Lines 17589 17614 +25 ==========================================
+ Hits 9238 9256 +18 - Misses 7657 7664 +7 
Partials 694 694 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewnester
andrewnester added this pull request to the merge queueMar 4, 2024
Merged via the queue into main with commit 09d1846Mar 4, 2024
@andrewnester
andrewnester deleted the fix-sp-lookup branch March 4, 2024 16:19
pietern added a commit that referenced this pull request Mar 6, 2024
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large files.
Bundles:
* Fix summary command when internal Terraform config doesn't exist ([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable ([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL ([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update ([#1251](#1251)).
* Only transform wheel libraries when using trampoline ([#1248](#1248)).
* Return `application_id` for service principal lookups ([#1245](#1245)).
* Support relative paths in artifact files source section and always upload all artifact files ([#1247](#1247)).
* Fix DBConnect support in VS Code ([#1253](#1253)).
Internal:
* Added test to verify scripts.Execute mutator works correctly ([#1237](#1237)).
API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index` command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index` command with new required argument order.
OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)
Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1252](#1252)).
* Update Go SDK to v0.34.0 ([#1256](#1256)).
@pieternpietern mentioned this pull request Mar 6, 2024
github-merge-queueBot pushed a commit that referenced this pull request Mar 6, 2024
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large
files.
Bundles:
* Fix summary command when internal Terraform config doesn't exist
([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable
([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL
([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update
([#1251](#1251)).
* Only transform wheel libraries when using trampoline
([#1248](#1248)).
* Return `application_id` for service principal lookups
([#1245](#1245)).
* Support relative paths in artifact files source section and always
upload all artifact files
([#1247](#1247)).
* Fix DBConnect support in VS Code
([#1253](#1253)).
Internal:
* Added test to verify scripts.Execute mutator works correctly
([#1237](#1237)).
API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account
settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command
with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with
new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index`
command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index`
command with new required argument order.
OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)
Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#1252](#1252)).
* Update Go SDK to v0.34.0
([#1256](#1256)).
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
Return ApplicationId for service principals lookups
Fixes#1234 ## Tests
Added (regression) tests
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large
files.
Bundles:
* Fix summary command when internal Terraform config doesn't exist
([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable
([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL
([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update
([#1251](#1251)).
* Only transform wheel libraries when using trampoline
([#1248](#1248)).
* Return `application_id` for service principal lookups
([#1245](#1245)).
* Support relative paths in artifact files source section and always
upload all artifact files
([#1247](#1247)).
* Fix DBConnect support in VS Code
([#1253](#1253)).
Internal:
* Added test to verify scripts.Execute mutator works correctly
([#1237](#1237)).
API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account
settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command
with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with
new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index`
command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index`
command with new required argument order.
OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)
Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#1252](#1252)).
* Update Go SDK to v0.34.0
([#1256](#1256)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lookup: service_principal not giving correct id

3 participants

@andrewnester@codecov-commenter@pietern