Skip to content

Configure cobra.NoArgs for bundle commands where applicable - #1250

Merged
pietern merged 1 commit into
mainfrom
deploy-no-args
Mar 1, 2024
Merged

Configure cobra.NoArgs for bundle commands where applicable#1250
pietern merged 1 commit into
mainfrom
deploy-no-args

Conversation

@pietern

Copy link
Copy Markdown
Contributor

Changes

Return an error if unused arguments are passed to these commands.

Tests

n/a

@pietern
pietern enabled auto-merge March 1, 2024 15:30
@codecov-commenter

codecov-commenter commented Mar 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 52.50%. Comparing base (d12f88e) to head (32333de).

FilesPatch %Lines
cmd/bundle/destroy.go0.00%3 Missing ⚠️
cmd/bundle/summary.go0.00%3 Missing ⚠️
cmd/bundle/validate.go0.00%3 Missing ⚠️
cmd/bundle/run.go0.00%2 Missing ⚠️
cmd/bundle/deploy.go0.00%1 Missing ⚠️
cmd/bundle/schema.go0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1250 +/- ##
==========================================
- Coverage 52.50% 52.50% -0.01% 
==========================================
Files 308 308 Lines 17594 17595 +1 ==========================================
Hits 9238 9238 - Misses 7662 7663 +1 
Partials 694 694 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pietern
pietern added this pull request to the merge queueMar 1, 2024
Merged via the queue into main with commit e140703Mar 1, 2024
@pietern
pietern deleted the deploy-no-args branch March 1, 2024 16:04
pietern added a commit that referenced this pull request Mar 6, 2024
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large files.
Bundles:
* Fix summary command when internal Terraform config doesn't exist ([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable ([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL ([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update ([#1251](#1251)).
* Only transform wheel libraries when using trampoline ([#1248](#1248)).
* Return `application_id` for service principal lookups ([#1245](#1245)).
* Support relative paths in artifact files source section and always upload all artifact files ([#1247](#1247)).
* Fix DBConnect support in VS Code ([#1253](#1253)).
Internal:
* Added test to verify scripts.Execute mutator works correctly ([#1237](#1237)).
API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index` command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index` command with new required argument order.
OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)
Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 ([#1252](#1252)).
* Update Go SDK to v0.34.0 ([#1256](#1256)).
@pieternpietern mentioned this pull request Mar 6, 2024
github-merge-queueBot pushed a commit that referenced this pull request Mar 6, 2024
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large
files.
Bundles:
* Fix summary command when internal Terraform config doesn't exist
([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable
([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL
([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update
([#1251](#1251)).
* Only transform wheel libraries when using trampoline
([#1248](#1248)).
* Return `application_id` for service principal lookups
([#1245](#1245)).
* Support relative paths in artifact files source section and always
upload all artifact files
([#1247](#1247)).
* Fix DBConnect support in VS Code
([#1253](#1253)).
Internal:
* Added test to verify scripts.Execute mutator works correctly
([#1237](#1237)).
API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account
settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command
with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with
new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index`
command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index`
command with new required argument order.
OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)
Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#1252](#1252)).
* Update Go SDK to v0.34.0
([#1256](#1256)).
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
Return an error if unused arguments are passed to these commands.
## Tests
n/a
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* The SDK update fixes `fs cp` calls timing out when copying large
files.
Bundles:
* Fix summary command when internal Terraform config doesn't exist
([#1242](#1242)).
* Configure cobra.NoArgs for bundle commands where applicable
([#1250](#1250)).
* Fixed building Python artifacts on Windows with WSL
([#1249](#1249)).
* Add `--validate-only` flag to run validate-only pipeline update
([#1251](#1251)).
* Only transform wheel libraries when using trampoline
([#1248](#1248)).
* Return `application_id` for service principal lookups
([#1245](#1245)).
* Support relative paths in artifact files source section and always
upload all artifact files
([#1247](#1247)).
* Fix DBConnect support in VS Code
([#1253](#1253)).
Internal:
* Added test to verify scripts.Execute mutator works correctly
([#1237](#1237)).
API Changes:
* Added `databricks permission-migration` command group.
* Updated nesting of the `databricks settings` and `databricks account
settings commands`
* Changed `databricks vector-search-endpoints delete-endpoint` command
with new required argument order.
* Changed `databricks vector-search-indexes create-index` command with
new required argument order.
* Changed `databricks vector-search-indexes delete-data-vector-index`
command with new required argument order.
* Changed `databricks vector-search-indexes upsert-data-vector-index`
command with new required argument order.
OpenAPI commit d855b30f25a06fe84f25214efa20e7f1fffcdf9e (2024-03-04)
Dependency updates:
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#1252](#1252)).
* Update Go SDK to v0.34.0
([#1256](#1256)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pietern@codecov-commenter@andrewnester