Uh oh!
There was an error while loading. Please reload this page.
Add acceptance for test for sync.paths equal to two dots - #2196
Merged
Conversation
Based on integration test from @andrewnester in #2194
denik
requested review from
andrewnester, pietern and shreyas-goenka
as code ownersJanuary 20, 2025 20:58
denikforce-pushed
the
denik/test-root-outside
branch
from
January 20, 2025 21:08
ebb1bbc to
8c8885dComparedenik
enabled auto-merge
January 20, 2025 21:16
denik
disabled auto-merge
January 21, 2025 08:26
denik
enabled auto-merge
January 21, 2025 08:32
andrewnester
approved these changes
Jan 21, 2025
| @@ -0,0 +1 @@ | |||
| $CLI bundle validate | |||
Contributor
There was a problem hiding this comment.
Oh, I didn't realise it's reproducible by validate as well, struggled to right it for deploy
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Jan 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
pietern
commented
Jan 21, 2025
Contributor
@denik Does this never work or only if the directory is not contained in a Git repository? We can run the same test case when |
denik added a commit
that referenced
this pull request
May 20, 2026
Based on integration test from @andrewnester in #2194 Manually checked that this databricks.yml passes validation on v0.235.0 but fails on v0.236.0, very like it was broken in #1945 This also adds replacements for tmpdir, it's parent and (just in case) grand parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on integration test from @andrewnester in #2194
Manually checked that this databricks.yml passes validation on v0.235.0 but fails on v0.236.0, most likely it was broken in #1945
This also adds replacements for tmpdir, it's parent and (just in case) grand parent.