Uh oh!
There was an error while loading. Please reload this page.
Set WorktreeRoot to sync root outside git repo - #2197
Merged
Conversation
denik
requested review from
andrewnester, pietern and shreyas-goenka
as code ownersJanuary 20, 2025 21:12
ContributorAuthor
Note, cmd/sync/sync.go might have a similar problem, not addressed here. |
denik
marked this pull request as draft
January 21, 2025 07:40
andrewnester
approved these changes
Jan 21, 2025
pietern
reviewed
Jan 21, 2025
pietern
left a comment
Contributor
There was a problem hiding this comment.
I understand now -- this is only an issue if we cannot fetch Git metadata, i.e. when working without Git or on an extracted archive of a repo. Very subtle. Glad we can more easily catch this class of problem through acceptance tests in the future.
denikforce-pushed
the
denik/fix-sync-root-validation
branch
from
January 22, 2025 09:48
745b7c9 to
a0cd1a9Comparedenikforce-pushed
the
denik/fix-sync-root-validation
branch
from
January 22, 2025 09:58
a0cd1a9 to
f1884b7Comparedenik
marked this pull request as ready for review
January 22, 2025 10:05
pietern
approved these changes
Jan 22, 2025
denikforce-pushed
the
denik/fix-sync-root-validation
branch
from
January 22, 2025 10:31
f1884b7 to
fc56d15Comparedenik
enabled auto-merge
January 22, 2025 10:42
andrewnester added a commit
that referenced
this pull request
Jan 23, 2025
CLI: * Added text output templates for apps list and list-deployments ([#2175](#2175)). * Fix duplicate "apps" entry in help output ([#2191](#2191)). Bundles: * Allow yaml-anchors in schema ([#2200](#2200)). * Show an error when non-yaml files used in include section ([#2201](#2201)). * Set WorktreeRoot to sync root outside git repo ([#2197](#2197)). * fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)). * Allow using variables in enum fields ([#2199](#2199)). * Add experimental-jobs-as-code template ([#2177](#2177)). * Reading variables from file ([#2171](#2171)). * Fixed an apps message order and added output test ([#2174](#2174)). * Default to forward slash-separated paths for path translation ([#2145](#2145)). * Include a materialized copy of built-in templates ([#2146](#2146)).
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jan 23, 2025
CLI: * Added text output templates for apps list and list-deployments ([#2175](#2175)). * Fix duplicate "apps" entry in help output ([#2191](#2191)). Bundles: * Allow yaml-anchors in schema ([#2200](#2200)). * Show an error when non-yaml files used in include section ([#2201](#2201)). * Set WorktreeRoot to sync root outside git repo ([#2197](#2197)). * fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)). * Allow using variables in enum fields ([#2199](#2199)). * Add experimental-jobs-as-code template ([#2177](#2177)). * Reading variables from file ([#2171](#2171)). * Fixed an apps message order and added output test ([#2174](#2174)). * Default to forward slash-separated paths for path translation ([#2145](#2145)). * Include a materialized copy of built-in templates ([#2146](#2146)).
denik pushed a commit
that referenced
this pull request
May 20, 2026
CLI: * Added text output templates for apps list and list-deployments ([#2175](#2175)). * Fix duplicate "apps" entry in help output ([#2191](#2191)). Bundles: * Allow yaml-anchors in schema ([#2200](#2200)). * Show an error when non-yaml files used in include section ([#2201](#2201)). * Set WorktreeRoot to sync root outside git repo ([#2197](#2197)). * fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)). * Allow using variables in enum fields ([#2199](#2199)). * Add experimental-jobs-as-code template ([#2177](#2177)). * Reading variables from file ([#2171](#2171)). * Fixed an apps message order and added output test ([#2174](#2174)). * Default to forward slash-separated paths for path translation ([#2145](#2145)). * Include a materialized copy of built-in templates ([#2146](#2146)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If git is not detected, set default worktree root to sync root. Otherwise NewFileSet/View raise an error about worktree root being outside view root in acceptance/bundle/sync-paths-dotdot.
This behavior is introduced in #1945
Stacked on #2202
Tests
Existing tests.