Skip to content

Show an error when non-yaml files used in include section - #2201

Merged
andrewnester merged 6 commits into
mainfrom
fix-yaml-includes
Jan 23, 2025
Merged

Show an error when non-yaml files used in include section#2201
andrewnester merged 6 commits into
mainfrom
fix-yaml-includes

Conversation

@andrewnester

@andrewnesterandrewnester commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

Changes

include section is used only to include other bundle configuration YAML files. If any other file type is used, raise an error and guide users to use sync.include instead

Tests

Added acceptance test

pietern
pietern reviewed Jan 21, 2025
View reviewed changes
Comment threadbundle/config/loader/process_root_includes.go Outdated
pietern
pietern approved these changes Jan 21, 2025
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliacrawf-db Could you TAL at the message + call to action?

juliacrawf-db
juliacrawf-db reviewed Jan 22, 2025
View reviewed changes
Comment threadbundle/config/loader/process_root_includes.go Outdated
juliacrawf-db
juliacrawf-db reviewed Jan 22, 2025
View reviewed changes
Comment threadbundle/config/loader/process_root_includes.go Outdated
juliacrawf-db
juliacrawf-db reviewed Jan 22, 2025
View reviewed changes
Comment threadacceptance/bundle/includes/non_yaml_in_include/output.txt
@andrewnester@juliacrawf-db
Update bundle/config/loader/process_root_includes.go
abe8168
Co-authored-by: Julia Crawford (Databricks) <julia.crawford@databricks.com>
@andrewnester@juliacrawf-db
Update bundle/config/loader/process_root_includes.go
4789d1f
Co-authored-by: Julia Crawford (Databricks) <julia.crawford@databricks.com>
@andrewnester
andrewnester added this pull request to the merge queueJan 23, 2025
Merged via the queue into main with commit 8af9efaJan 23, 2025
@andrewnester
andrewnester deleted the fix-yaml-includes branch January 23, 2025 14:11
andrewnester added a commit that referenced this pull request Jan 23, 2025
@andrewnester
[Release] Release v0.239.1
aebe0a6
CLI:
* Added text output templates for apps list and list-deployments ([#2175](#2175)).
* Fix duplicate "apps" entry in help output ([#2191](#2191)).
Bundles:
* Allow yaml-anchors in schema ([#2200](#2200)).
* Show an error when non-yaml files used in include section ([#2201](#2201)).
* Set WorktreeRoot to sync root outside git repo ([#2197](#2197)).
* fix: Detailed message for using source-linked deployment with file_path specified ([#2119](#2119)).
* Allow using variables in enum fields ([#2199](#2199)).
* Add experimental-jobs-as-code template ([#2177](#2177)).
* Reading variables from file ([#2171](#2171)).
* Fixed an apps message order and added output test ([#2174](#2174)).
* Default to forward slash-separated paths for path translation ([#2145](#2145)).
* Include a materialized copy of built-in templates ([#2146](#2146)).
@andrewnesterandrewnester mentioned this pull request Jan 23, 2025
Merged
github-merge-queueBot pushed a commit that referenced this pull request Jan 23, 2025
@andrewnester
[Release] Release v0.239.1 (#2218)
d784147
CLI:
* Added text output templates for apps list and list-deployments
([#2175](#2175)).
* Fix duplicate "apps" entry in help output
([#2191](#2191)).
Bundles:
* Allow yaml-anchors in schema
([#2200](#2200)).
* Show an error when non-yaml files used in include section
([#2201](#2201)).
* Set WorktreeRoot to sync root outside git repo
([#2197](#2197)).
* fix: Detailed message for using source-linked deployment with
file_path specified
([#2119](#2119)).
* Allow using variables in enum fields
([#2199](#2199)).
* Add experimental-jobs-as-code template
([#2177](#2177)).
* Reading variables from file
([#2171](#2171)).
* Fixed an apps message order and added output test
([#2174](#2174)).
* Default to forward slash-separated paths for path translation
([#2145](#2145)).
* Include a materialized copy of built-in templates
([#2146](#2146)).
spoltier added a commit to spoltier/databricks-cli that referenced this pull request Jan 29, 2025
@spoltier
accept JSON includes
324b76a
databricks#2201 disabled using JSON as part of a bundle definition. I believe this was not intended.
@spoltierspoltier mentioned this pull request Jan 29, 2025
Merged
andrewnester pushed a commit that referenced this pull request Feb 4, 2025
@spoltier
accept JSON includes (#2265)
84b694f
#2201 disabled using JSON as part of a bundle definition. I believe this
was not intended.
## Changes
Accept json files as includes, just as YAML files.
## Tests
Covered by the tests in #2201
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester@juliacrawf-db
Show an error when non-yaml files used in include section (#2201)
385c484
## Changes
`include` section is used only to include other bundle configuration
YAML files. If any other file type is used, raise an error and guide
users to use `sync.include` instead
## Tests
Added acceptance test
---------
Co-authored-by: Julia Crawford (Databricks) <julia.crawford@databricks.com>
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
[Release] Release v0.239.1 (#2218)
a2bcd36
CLI:
* Added text output templates for apps list and list-deployments
([#2175](#2175)).
* Fix duplicate "apps" entry in help output
([#2191](#2191)).
Bundles:
* Allow yaml-anchors in schema
([#2200](#2200)).
* Show an error when non-yaml files used in include section
([#2201](#2201)).
* Set WorktreeRoot to sync root outside git repo
([#2197](#2197)).
* fix: Detailed message for using source-linked deployment with
file_path specified
([#2119](#2119)).
* Allow using variables in enum fields
([#2199](#2199)).
* Add experimental-jobs-as-code template
([#2177](#2177)).
* Reading variables from file
([#2171](#2171)).
* Fixed an apps message order and added output test
([#2174](#2174)).
* Default to forward slash-separated paths for path translation
([#2145](#2145)).
* Include a materialized copy of built-in templates
([#2146](#2146)).
denik pushed a commit that referenced this pull request May 20, 2026
@spoltier
accept JSON includes (#2265)
d860020
#2201 disabled using JSON as part of a bundle definition. I believe this
was not intended.
## Changes
Accept json files as includes, just as YAML files.
## Tests
Covered by the tests in #2201
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliacrawf-dbjuliacrawf-dbjuliacrawf-db left review comments
@pieternpieternpietern approved these changes
@denikdenikdenik approved these changes
@shreyas-goenkashreyas-goenkaAwaiting requested review from shreyas-goenka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewnester@pietern@denik@juliacrawf-db